Remove similarmatrixtype

Author: kshyatt

ext/TensorKitCUDAExt/TensorKitCUDAExt.jl

@@ -23,8 +23,6 @@ using Random
 include("cutensormap.jl")
 include("truncation.jl")
 
-TensorKit.similarmatrixtype(::Type{A}) where {T <: Number, M, A <: CuVector{T, M}} = CuMatrix{T, M}
-
 function TensorKit._set_subblock!(data::TD, val) where {T, TD <: Union{<:CuMatrix{T}, <:StridedViews.StridedView{T, 4, <:CuArray{T}}}}
     @kernel function fill_subblock_kernel!(subblock, val)
         idx = @index(Global, Cartesian)

src/tensors/abstracttensor.jl

@@ -122,19 +122,6 @@ similarstoragetype(::Type{D}, ::Type{T}) where {D <: AbstractDict{<:Sector, <:Ab
 # default storage type for numbers
 similarstoragetype(::Type{T}) where {T <: Number} = Vector{T}
 
-@doc """
-    similarmatrixtype(T::Type{<:Number}) -> Matrix{T}
-    similarmatrixtype(A::Type{T, <:DenseVector{T}}) -> Matrix{T}
-
-For a given dense vector type `A` or number type `T`, compute an appropriate
-**matrix** storage type for tensors. This function is used internally for
-[`BraidingTensor`](@ref) to determine the output storage format for indexing
-and other operations with other tensor types.
-""" similarmatrixtype
-
-similarmatrixtype(::Type{T}) where {T <: Number} = Matrix{T}
-similarmatrixtype(::Type{A}) where {T <: Number, A <: DenseVector{T}} = Matrix{T}
-
 @doc """
     promote_storagetype([T], A, B, C...)
     promote_storagetype([T], TA, TB, TC...)

src/tensors/braidingtensor.jl

@@ -135,8 +135,8 @@ end
     d = (dims(codomain(b), f₁.uncoupled)..., dims(domain(b), f₂.uncoupled)...)
     n1 = d[1] * d[2]
     n2 = d[3] * d[4]
-    data_t = similarmatrixtype(storagetype(b))(undef, (n1, n2))
-    data = sreshape(StridedView(data_t), d)
+    data_parent = storagetype(b)(undef, prod(d))
+    data = sreshape(StridedView(data_parent), d)
     fill!(data, zero(eltype(b)))
 
     r = _braiding_factor(f₁, f₂, b.adjoint)
@@ -186,10 +186,10 @@ function block(b::BraidingTensor, s::Sector)
     m = blockdim(codomain(b), s)
     n = blockdim(domain(b), s)
 
-    m * n == 0  && return similarmatrixtype(storagetype(b))(undef, (m, n)) # s ∉ blocksectors(b)
+    data = reshape(storagetype(b)(undef, m * n), (m, n))
 
-    data = similarmatrixtype(storagetype(b))(undef, (m, n))
-    data = fill!(data, zero(eltype(b)))
+    m * n == 0  && return data # s ∉ blocksectors(b)
+    fill!(data, zero(eltype(b)))
 
     if sectortype(b) === Trivial
         return _trivial_subblock!(data, b)