Skip to content

Allow twisting of trivial sectors without restrictions#240

Merged
lkdvos merged 2 commits intomasterfrom
twist
Apr 12, 2025
Merged

Allow twisting of trivial sectors without restrictions#240
lkdvos merged 2 commits intomasterfrom
twist

Conversation

@lkdvos
Copy link
Copy Markdown
Member

@lkdvos lkdvos commented Apr 7, 2025

Enable twisting of trivial sectors in cases where no braiding is defined, similar to how braiding trivial sectors is special cased.

Fixes #239

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.61%. Comparing base (ec7ee9d) to head (87301b5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/tensors/indexmanipulations.jl 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
- Coverage   82.68%   82.61%   -0.08%     
==========================================
  Files          43       43              
  Lines        5573     5579       +6     
==========================================
+ Hits         4608     4609       +1     
- Misses        965      970       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jutho
Copy link
Copy Markdown
Member

Jutho commented Apr 11, 2025

Looks good; feel free to merge.

Note: it would be good to have tests for both the braiding and twisting behaviour of indices with a unit sector at some point. However, we currently don't even have any non-group symmetric tensor tests.

@lkdvos
Copy link
Copy Markdown
Member Author

lkdvos commented Apr 12, 2025

MPSKit remains a somewhat decent test suite of this, since it's actually being used there :)

I was actually quite surprised to find that the trivial braiding thing worked, and had to dig through the code a bit to find out how this was being achieved.

@lkdvos lkdvos merged commit ed09f13 into master Apr 12, 2025
10 of 14 checks passed
@lkdvos lkdvos deleted the twist branch April 12, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

twist for NoBraiding sector types where the braiding is unambiguous

2 participants