add rrule for flip#241
Conversation
|
Can you also add a test? See https://github.com/Jutho/TensorKit.jl/blob/ed09f138e41d8a69a703f6473e4acbb2838f2fb5/test/ad.jl#L224 |
|
It turns out that this is not the right |
|
That sounds ... honestly scary 😬 It might be good to add a note of this in the docstring, since this is definitely something I would have wrongly assumed. Possibly we could mimick the |
|
It essentially amounts to saying that flipping twice corresponds exactly to how you get the Frobenius-Schur indicator, which is ±1. An |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #241 +/- ##
==========================================
+ Coverage 82.61% 82.65% +0.04%
==========================================
Files 43 43
Lines 5579 5593 +14
==========================================
+ Hits 4609 4623 +14
Misses 970 970 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The failures are again related to ChainRulesTestUtils on Julia nightly (Julia 1.13). I checked at my own machine weather everything works on beta (Julia 1.12), and there everything seems fine, so I think this is good to go, unless there are further comments. |
fix spelling mistake Co-authored-by: Lukas Devos <ldevos98@gmail.com>
|
Great catch; I don't think we need another CI run for this so I will merge. (BTW: copilot completion also thought involutive, but I think that is wrong). |
This implements the rrule for the function flip().