[Fix] Transformers for non-abelian non-selfadjoint sectors#256
Merged
[Fix] Transformers for non-abelian non-selfadjoint sectors#256
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #256 +/- ##
=======================================
Coverage 82.90% 82.90%
=======================================
Files 44 44
Lines 5751 5751
=======================================
Hits 4768 4768
Misses 983 983 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jutho
reviewed
Jul 12, 2025
| sz_median = size(data[end ÷ 2][1], 1), | ||
| sz_max = size(data[1][1], 1), | ||
| sz_median = size(data[cld(end, 2)][1], 1), | ||
| sz_max = size(data[cld(end, 2)][1], 1), |
Member
There was a problem hiding this comment.
Are sz_median and sz_max now the same? Do you just want data[end][1]?
Member
Author
There was a problem hiding this comment.
Oh you are right, I should have only corrected the sz_median. Should be resolved now.
Jutho
approved these changes
Jul 12, 2025
Member
Jutho
left a comment
Jutho
left a comment
There was a problem hiding this comment.
Looks good to merge; do you also bump the patch version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As brought up in #255 , for sectors that are non-abelian and not self-adjoint the logic for locating the fusiontrees was being handled incorrectly.
Here, I've fixed that, and added a set of spaces that have this property to the testsuite.
An alternative would be to re-enable the SU3 tests, but I think this testset is also useful by itself.