-
Notifications
You must be signed in to change notification settings - Fork 60
Show improvements + subblocks iterator
#304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
8ca49b8
rework gradedspace show
lkdvos a6e091a
rework tensor show
lkdvos f48e980
add convenience functions
lkdvos a2b595f
rework tensor show again
lkdvos 9710451
rework adjoint tensor show
lkdvos f121193
update blockshow
lkdvos 070dab2
add `SubblockIterator`
lkdvos 53f0b61
rework diagonal tensor show
lkdvos fe20385
some indexing reworking
lkdvos 1586be7
adjoint indexing
lkdvos 5fcd778
diagonal indexing
lkdvos a7a6af4
remove double export
lkdvos cdd6649
small doc changes
lkdvos 077de13
remove vertical gradedspace printing
lkdvos 4bbdb93
retry gradedspace printing
lkdvos 1c156fe
improve errors
lkdvos 53a5dc9
remove ambiguous function
lkdvos e1ef363
simplify dual
lkdvos 9266ed9
use reduced dim
lkdvos 0285d36
address pr comments
lkdvos 4c77cb3
code review
lkdvos f2a10c1
remove controversy
lkdvos 992f5c2
simplify gradedarray printing
lkdvos 18dd4ee
avoid function call in show
lkdvos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is in principle a private function, though I am not opposed to using it. But it could easily be broken in a next Julia release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree that in principle we should probably vendor this ourselves. Unfortunately it is actually quite ugly/involved, so I would really prefer to not have to do so, and it might actually require less effort to simply update this function if Julia breaks it...