Skip to content

Fix for SUNRepresentations type parameter change#426

Merged
lkdvos merged 3 commits into
mainfrom
lb/su3_fix
May 11, 2026
Merged

Fix for SUNRepresentations type parameter change#426
lkdvos merged 3 commits into
mainfrom
lb/su3_fix

Conversation

@leburgel
Copy link
Copy Markdown
Member

Small fix in the symmetric tensor tutorial for SUNRepresentations v0.4, where SUNIrrep{3} has become an abstract type. It anyway made no sense to mix SU3Irrep and SUNIrrep{3} in the same line, looks needlessly confusing.

If we want, I can also bump the SUNRepresentations compat entry to v0.4 in the docs project, so we can use SUNRepresentations.casimir instead of having to define our own casimir method. It's quite pedagogical the way it is so I didn't do this right away, but if this would be better I'll change it.

@lkdvos
Copy link
Copy Markdown
Member

lkdvos commented May 11, 2026

I would actually be in favor of using SUNRepresentations.casimir as that helps visibility of that method, and I think the pedagogical part is more about using it than defining it?

Btw, could you then also update the [compat] in the docs Project.toml?

@github-actions
Copy link
Copy Markdown
Contributor

After the build completes, the updated documentation will be available here

@lkdvos lkdvos merged commit befefcb into main May 11, 2026
1 of 2 checks passed
@lkdvos lkdvos deleted the lb/su3_fix branch May 11, 2026 21:32
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants