Skip to content

Enzyme doesn't need a custom rule for trace_permute#480

Merged
lkdvos merged 2 commits into
mainfrom
ksh/enz_trace
Jul 14, 2026
Merged

Enzyme doesn't need a custom rule for trace_permute#480
lkdvos merged 2 commits into
mainfrom
ksh/enz_trace

Conversation

@kshyatt

@kshyatt kshyatt commented Jul 13, 2026

Copy link
Copy Markdown
Member

Noticed that this seemed to be working sans custom rule locally. Let's see how it does for all the test cases.

@kshyatt

kshyatt commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

Apparently this works now with a custom set of rules for subblock!

@kshyatt
kshyatt requested review from Jutho and lkdvos July 14, 2026 12:19
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Your PR no longer requires formatting changes. Thank you for your contribution!

@kshyatt kshyatt changed the title Does Enzyme need a custom rule for trace_permute Enzyme doesn't need a custom rule for trace_permute Jul 14, 2026

@lkdvos lkdvos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@kshyatt

kshyatt commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

It seems to have helped with compile times too 🧐

@kshyatt
kshyatt marked this pull request as ready for review July 14, 2026 13:44
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 53.33333% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ext/TensorKitEnzymeExt/utility.jl 53.33% 14 Missing ⚠️
Files with missing lines Coverage Δ
ext/TensorKitEnzymeExt/TensorKitEnzymeExt.jl 100.00% <ø> (ø)
ext/TensorKitEnzymeExt/tensoroperations.jl 82.22% <ø> (+1.73%) ⬆️
ext/TensorKitEnzymeExt/utility.jl 38.00% <53.33%> (+23.00%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos
lkdvos merged commit 832ceb7 into main Jul 14, 2026
78 of 79 checks passed
@lkdvos
lkdvos deleted the ksh/enz_trace branch July 14, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants