Skip to content

add fusion product iterator test#99

Merged
borisdevos merged 7 commits into
mainfrom
bd/fusionproditerator
Jun 22, 2026
Merged

add fusion product iterator test#99
borisdevos merged 7 commits into
mainfrom
bd/fusionproditerator

Conversation

@borisdevos

@borisdevos borisdevos commented Jun 22, 2026

Copy link
Copy Markdown
Member

Test whether the fusion product iterator was implemented correctly. Not sure if this should be extended to also check via N-symbols?

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/multifusion.jl 88.46% <100.00%> (+1.22%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/multifusion.jl Outdated
Comment thread test/sectors.jl Outdated
end
end

@testsuite "Fusion product iterator" I -> begin

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need a guard to only check this if the iteratorsize is haslength. In principle we always expect this to be true, but sometimes it can be convenient to have size unknown if the implementation is annoying.

As a separate question, maybe this can go together with the check on the dimensions just below here?

@borisdevos borisdevos Jun 22, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need a guard to only check this if the iteratorsize is haslength. In principle we always expect this to be true, but sometimes it can be convenient to have size unknown if the implementation is annoying.

How will this then work for sector types which don't use SectorProductIterator? Do we just skip those?
Edit: I forgot other iterator types have an iterator size property

As a separate question, maybe this can go together with the check on the dimensions just below here?

I don't mind combining them

Comment thread src/multifusion.jl Outdated
@borisdevos borisdevos merged commit c697bb2 into main Jun 22, 2026
12 checks passed
@borisdevos borisdevos deleted the bd/fusionproditerator branch June 22, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants