-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
fix(openai): support streaming image relay and image edit for images API #4608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gaoren002
wants to merge
5
commits into
QuantumNous:main
Choose a base branch
from
gaoren002:pr/openai-image-stream-keepalive-20260504130050
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9d13ce8
fix(openai): support streaming image relay
9cc9542
fix(openai): keep image edit multipart body reusable
47ba6ee
test(openai): cover image stream usage details
71a66dc
test(openai): cover image edit fallback stream field
26b87a1
Merge branch 'QuantumNous:main' into pr/openai-image-stream-keepalive…
gaoren002 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| package dto | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| // TestImageRequestStreamJSON verifies that image requests preserve stream=true. | ||
| func TestImageRequestStreamJSON(t *testing.T) { | ||
| var req ImageRequest | ||
| require.NoError(t, req.UnmarshalJSON([]byte(`{"model":"gpt-image-1","prompt":"draw a cat","stream":true}`))) | ||
|
|
||
| require.True(t, req.Stream) | ||
| require.True(t, req.IsStream(nil)) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| package openai | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "io" | ||
| "mime/multipart" | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "testing" | ||
|
|
||
| "github.com/QuantumNous/new-api/common" | ||
| "github.com/QuantumNous/new-api/dto" | ||
| relaycommon "github.com/QuantumNous/new-api/relay/common" | ||
| relayconstant "github.com/QuantumNous/new-api/relay/constant" | ||
| "github.com/gin-gonic/gin" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| // TestConvertImageEditRequestKeepsValidMultipartStreamFields verifies multipart replay. | ||
| func TestConvertImageEditRequestKeepsValidMultipartStreamFields(t *testing.T) { | ||
| gin.SetMode(gin.TestMode) | ||
|
|
||
| var body bytes.Buffer | ||
| writer := multipart.NewWriter(&body) | ||
| require.NoError(t, writer.WriteField("model", "gpt-image-1")) | ||
| require.NoError(t, writer.WriteField("prompt", "edit this image")) | ||
| require.NoError(t, writer.WriteField("stream", "true")) | ||
| require.NoError(t, writer.WriteField("partial_images", "3")) | ||
| part, err := writer.CreateFormFile("image", "input.png") | ||
| require.NoError(t, err) | ||
| _, err = part.Write([]byte("fake image")) | ||
| require.NoError(t, err) | ||
| require.NoError(t, writer.Close()) | ||
|
|
||
| recorder := httptest.NewRecorder() | ||
| c, _ := gin.CreateTestContext(recorder) | ||
| c.Request = httptest.NewRequest(http.MethodPost, "/v1/images/edits", &body) | ||
| c.Request.Header.Set("Content-Type", writer.FormDataContentType()) | ||
| require.NoError(t, c.Request.ParseMultipartForm(32<<20)) | ||
|
|
||
| info := &relaycommon.RelayInfo{ | ||
| RelayMode: relayconstant.RelayModeImagesEdits, | ||
| } | ||
| request := dto.ImageRequest{ | ||
| Model: "gpt-image-1", | ||
| Prompt: "edit this image", | ||
| Stream: true, | ||
| } | ||
|
|
||
| converted, err := (&Adaptor{}).ConvertImageRequest(c, info, request) | ||
| require.NoError(t, err) | ||
|
|
||
| convertedBody, ok := converted.(*bytes.Buffer) | ||
| require.True(t, ok) | ||
|
|
||
| contentType := c.Request.Header.Get("Content-Type") | ||
| replayedRequest := httptest.NewRequest(http.MethodPost, "/v1/images/edits", bytes.NewReader(convertedBody.Bytes())) | ||
| replayedRequest.Header.Set("Content-Type", contentType) | ||
| require.NoError(t, replayedRequest.ParseMultipartForm(32<<20)) | ||
|
|
||
| require.Equal(t, "gpt-image-1", replayedRequest.PostForm.Get("model")) | ||
| require.Equal(t, "edit this image", replayedRequest.PostForm.Get("prompt")) | ||
| require.Equal(t, "true", replayedRequest.PostForm.Get("stream")) | ||
| require.Equal(t, "3", replayedRequest.PostForm.Get("partial_images")) | ||
| require.Len(t, replayedRequest.MultipartForm.File["image"], 1) | ||
|
|
||
| file, err := replayedRequest.MultipartForm.File["image"][0].Open() | ||
| require.NoError(t, err) | ||
| defer file.Close() | ||
| fileBytes, err := io.ReadAll(file) | ||
| require.NoError(t, err) | ||
| require.Equal(t, []byte("fake image"), fileBytes) | ||
| } | ||
|
|
||
| // TestConvertImageEditRequestParsesReusableMultipartWhenFormIsMissing verifies fallback parsing. | ||
| func TestConvertImageEditRequestParsesReusableMultipartWhenFormIsMissing(t *testing.T) { | ||
| gin.SetMode(gin.TestMode) | ||
|
|
||
| var body bytes.Buffer | ||
| writer := multipart.NewWriter(&body) | ||
| require.NoError(t, writer.WriteField("model", "gpt-image-1")) | ||
| require.NoError(t, writer.WriteField("prompt", "edit without pre-parsed form")) | ||
| require.NoError(t, writer.WriteField("stream", "true")) | ||
| part, err := writer.CreateFormFile("image", "input.png") | ||
| require.NoError(t, err) | ||
| _, err = part.Write([]byte("fake image")) | ||
| require.NoError(t, err) | ||
| require.NoError(t, writer.Close()) | ||
|
|
||
| recorder := httptest.NewRecorder() | ||
| c, _ := gin.CreateTestContext(recorder) | ||
| c.Request = httptest.NewRequest(http.MethodPost, "/v1/images/edits", &body) | ||
| c.Request.Header.Set("Content-Type", writer.FormDataContentType()) | ||
|
|
||
| storage, err := common.GetBodyStorage(c) | ||
| require.NoError(t, err) | ||
| c.Request.Body = io.NopCloser(storage) | ||
| c.Request.MultipartForm = nil | ||
| c.Request.PostForm = nil | ||
|
|
||
| info := &relaycommon.RelayInfo{ | ||
| RelayMode: relayconstant.RelayModeImagesEdits, | ||
| } | ||
| request := dto.ImageRequest{ | ||
| Model: "gpt-image-1", | ||
| Prompt: "edit without pre-parsed form", | ||
| Stream: true, | ||
| } | ||
|
|
||
| converted, err := (&Adaptor{}).ConvertImageRequest(c, info, request) | ||
| require.NoError(t, err) | ||
|
|
||
| convertedBody, ok := converted.(*bytes.Buffer) | ||
| require.True(t, ok) | ||
| replayedRequest := httptest.NewRequest(http.MethodPost, "/v1/images/edits", bytes.NewReader(convertedBody.Bytes())) | ||
| replayedRequest.Header.Set("Content-Type", c.Request.Header.Get("Content-Type")) | ||
| require.NoError(t, replayedRequest.ParseMultipartForm(32<<20)) | ||
| require.Equal(t, "edit without pre-parsed form", replayedRequest.PostForm.Get("prompt")) | ||
| require.Equal(t, "true", replayedRequest.PostForm.Get("stream")) | ||
| require.Len(t, replayedRequest.MultipartForm.File["image"], 1) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| package openai | ||
|
|
||
| import ( | ||
| "io" | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/QuantumNous/new-api/constant" | ||
| "github.com/QuantumNous/new-api/dto" | ||
| relaycommon "github.com/QuantumNous/new-api/relay/common" | ||
| "github.com/gin-gonic/gin" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| // TestOpenaiImageStreamHandlerForwardsSSEAndUsage verifies image SSE passthrough. | ||
| func TestOpenaiImageStreamHandlerForwardsSSEAndUsage(t *testing.T) { | ||
| oldMode := gin.Mode() | ||
| gin.SetMode(gin.TestMode) | ||
| t.Cleanup(func() { gin.SetMode(oldMode) }) | ||
|
|
||
| oldTimeout := constant.StreamingTimeout | ||
| constant.StreamingTimeout = 30 | ||
| t.Cleanup(func() { constant.StreamingTimeout = oldTimeout }) | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| body := strings.Join([]string{ | ||
| `event: image_generation.partial_image`, | ||
| `data: {"type":"image_generation.partial_image","b64_json":"partial"}`, | ||
| ``, | ||
| `data: {"usage":{"input_tokens":3,"output_tokens":4,"total_tokens":7,"input_tokens_details":{"image_tokens":2,"text_tokens":1}}}`, | ||
| ``, | ||
| `data: [DONE]`, | ||
| ``, | ||
| }, "\n") | ||
|
|
||
| recorder := httptest.NewRecorder() | ||
| c, _ := gin.CreateTestContext(recorder) | ||
| c.Request = httptest.NewRequest(http.MethodPost, "/v1/images/generations", nil) | ||
|
|
||
| resp := &http.Response{ | ||
| StatusCode: http.StatusOK, | ||
| Body: io.NopCloser(strings.NewReader(body)), | ||
| Header: http.Header{"Content-Type": []string{"text/event-stream"}}, | ||
| } | ||
| info := &relaycommon.RelayInfo{ | ||
| ChannelMeta: &relaycommon.ChannelMeta{}, | ||
| IsStream: true, | ||
| } | ||
|
|
||
| usage, err := OpenaiImageStreamHandler(c, info, resp) | ||
| require.Nil(t, err) | ||
| require.Equal(t, 3, usage.PromptTokens) | ||
| require.Equal(t, 4, usage.CompletionTokens) | ||
| require.Equal(t, 7, usage.TotalTokens) | ||
| require.Equal(t, 2, usage.PromptTokensDetails.ImageTokens) | ||
| require.Equal(t, 1, usage.PromptTokensDetails.TextTokens) | ||
| require.Contains(t, recorder.Body.String(), `event: image_generation.partial_image`) | ||
| require.Contains(t, recorder.Body.String(), `data: {"type":"image_generation.partial_image","b64_json":"partial"}`) | ||
| require.Contains(t, recorder.Body.String(), `data: {"usage":{"input_tokens":3,"output_tokens":4,"total_tokens":7,"input_tokens_details":{"image_tokens":2,"text_tokens":1}}}`) | ||
| require.Contains(t, recorder.Body.String(), `data: [DONE]`) | ||
| require.Equal(t, "text/event-stream", recorder.Header().Get("Content-Type")) | ||
| } | ||
|
|
||
| // TestNormalizeOpenAIUsageMapsImageTokenDetailsWithoutDoubleCounting verifies ImageRatio inputs. | ||
| func TestNormalizeOpenAIUsageMapsImageTokenDetailsWithoutDoubleCounting(t *testing.T) { | ||
| usage := &dto.Usage{ | ||
| InputTokens: 5000, | ||
| OutputTokens: 4000, | ||
| InputTokensDetails: &dto.InputTokenDetails{ | ||
| CachedCreationTokens: 200, | ||
| ImageTokens: 1000, | ||
| TextTokens: 4000, | ||
| }, | ||
| } | ||
|
|
||
| normalizeOpenAIUsage(usage) | ||
|
|
||
| require.Equal(t, 5000, usage.PromptTokens) | ||
| require.Equal(t, 4000, usage.CompletionTokens) | ||
| require.Equal(t, 9000, usage.TotalTokens) | ||
| require.Equal(t, 200, usage.PromptTokensDetails.CachedCreationTokens) | ||
| require.Equal(t, 1000, usage.PromptTokensDetails.ImageTokens) | ||
| require.Equal(t, 4000, usage.PromptTokensDetails.TextTokens) | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.