Skip to content

fix(web): avoid rerendering custom homepage content #5633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qinhang3 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(web): avoid rerendering custom homepage content #5633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions web/classic/src/pages/Home/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ const Home = () => {
const endpointItems = API_ENDPOINTS.map((e) => ({ value: e }));
const [endpointIndex, setEndpointIndex] = useState(0);
const isChinese = i18n.language.startsWith('zh');
const showDefaultHomePage = homePageContentLoaded && homePageContent === '';

const displayHomePageContent = async () => {
setHomePageContent(localStorage.getItem('home_page_content') || '');
Expand Down Expand Up @@ -142,11 +143,14 @@ const Home = () => {
}, []);

useEffect(() => {
if (!showDefaultHomePage) {
return undefined;
}
const timer = setInterval(() => {
setEndpointIndex((prev) => (prev + 1) % endpointItems.length);
}, 3000);
return () => clearInterval(timer);
}, [endpointItems.length]);
}, [endpointItems.length, showDefaultHomePage]);

return (
<div className='classic-page-fill classic-home-page w-full overflow-x-hidden'>
Expand All @@ -155,7 +159,7 @@ const Home = () => {
onClose={() => setNoticeVisible(false)}
isMobile={isMobile}
/>
{homePageContentLoaded && homePageContent === '' ? (
{showDefaultHomePage ? (
<div className='classic-home-default w-full overflow-x-hidden'>
{/* Banner 部分 */}
<div className='classic-home-hero w-full border-b border-semi-color-border relative overflow-x-hidden'>
Expand Down