[codex] fix iOS WebKit markdown autolink bundle#5687
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughAdds a local WebKit-compatible GFM plugin for web/classic
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bf17259 to
75cdac4
Compare
|
Rebased this PR onto the latest The default frontend has since moved away from the Validation run locally:
I could not run the Bun workspace build here because this machine does not currently have |
Summary
remark-gfmwith a local GFM preset that excludesgfm-autolink-literalremark-gfmimports, including Streamdown, to the compatible preset during Rsbuild bundlingWhy
mdast-util-gfm-autolink-literal@2.0.1includes an email autolink regex with lookbehind syntax. iOS 16.1 WebKit cannot parse that regex, so any bundle containing it can fail before React mounts.Validation
cd web && npm exec --yes --package=bun -- bun install --frozen-lockfilecd web/default && npm exec --yes --package=bun -- bun run typecheckcd web/default && npm exec --yes --package=bun -- bun run buildrg --fixed-strings "(?<=^|\\s|\\p{P}|\\p{S})" web/default/dist web/default/src web/classic/src web/default/rsbuild.config.ts web/classic/rsbuild.config.tsreturned no matchesrg "gfmAutolinkLiteral|literalAutolinkEmail|mdast-util-gfm-autolink-literal" web/default/dist web/default/src web/classic/src web/default/rsbuild.config.ts web/classic/rsbuild.config.tsreturned no matchesgit diff --checkNote:
web/classicbuild currently fails onmainbecausedate-fns-tz@1.3.8resolves againstdate-fns@4exports, tracked separately in #5670 with an existing fix PR #5676. This PR intentionally does not duplicate that unrelated dependency fix.Fixes #5550
Summary by CodeRabbit