Skip to content

Commit 6f79989

Browse files
author
anon
committed
Cleanup dynamic types
1 parent 21d4be8 commit 6f79989

2 files changed

Lines changed: 10 additions & 9 deletions

File tree

qubesadmin/app.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,9 @@
5757
except ImportError:
5858
has_qubesdb = False
5959

60-
DeviceClass = typing.LiteralString
60+
# ["mic", "block", "pci", "usb", "webcam"]
61+
# but can be extended
62+
DeviceClass = str
6163

6264

6365
class VMCollection:
@@ -223,9 +225,7 @@ def list_vmclass(self) -> list[Klass]:
223225
vmclass = (
224226
self.qubesd_call("dom0", "admin.vmclass.List").decode().splitlines()
225227
)
226-
for e in vmclass:
227-
assert e in typing.get_args(Klass)
228-
return typing.cast(list[Klass], sorted(vmclass))
228+
return sorted(vmclass)
229229

230230
def list_deviceclass(self) -> list[DeviceClass]:
231231
"""Call Qubesd in order to obtain the device classes list"""
@@ -234,10 +234,8 @@ def list_deviceclass(self) -> list[DeviceClass]:
234234
.decode()
235235
.splitlines()
236236
)
237-
for e in deviceclasses:
238-
assert e in typing.get_args(DeviceClass)
239237

240-
return typing.cast(list[DeviceClass], sorted(deviceclasses))
238+
return sorted(deviceclasses)
241239

242240
def _refresh_pool_drivers(self) -> None:
243241
"""

qubesadmin/vm/__init__.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import typing
2828
import warnings
2929
from logging import Logger
30-
from typing import Literal
30+
from typing import Literal, TypeVar
3131

3232
import qubesadmin.exc
3333
import qubesadmin.storage
@@ -39,7 +39,10 @@
3939
if typing.TYPE_CHECKING:
4040
import qubesadmin.base
4141

42-
Klass = Literal["AppVM", "AdminVM", "TemplateVM", "DispVM", "StandaloneVM"]
42+
43+
# ["AppVM", "AdminVM", "TemplateVM", "DispVM", "StandaloneVM"]
44+
# but can be extended
45+
Klass = str
4346
PowerState = Literal["Transient", "Running", "Halted", "Paused",
4447
"Suspended", "Halting", "Dying", "Crashed", "NA"]
4548

0 commit comments

Comments
 (0)