Skip to content

Commit a329df7

Browse files
author
anon
committed
fixup! remove unnecessary todo
1 parent 1ae3186 commit a329df7

1 file changed

Lines changed: 1 addition & 6 deletions

File tree

qubesadmin/base.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ def qubesd_call(self, dest: str | None, method: str,
8383
:param payload_stream: file-like object to read payload from
8484
:return: Data returned by qubesd (string)
8585
'''
86-
# TODO I removed this because self.app should never be None
8786
dest: str = dest or self._method_dest
8887
if (
8988
getattr(self, "_redirect_dispvm_calls", False)
@@ -363,9 +362,6 @@ def unescape(line: bytes) -> Generator[int]:
363362
return
364363
for line in properties_str.splitlines():
365364
# decode newlines
366-
# TODO this will fail if unescape returns some `str` ??
367-
# Did we maybe copy-paste `unescape` from somewhere else
368-
# but we only use it for ints ?
369365
line_bytes = bytes(list(unescape(line)))
370366
name, property_str = line_bytes.split(b' ', 1)
371367
name = name.decode()
@@ -478,8 +474,7 @@ def refresh_cache(self, force: bool=False) -> None:
478474
assert list_data[-1] == '\n'
479475
self._names_list = [str(name) for name in list_data[:-1].splitlines()]
480476

481-
# TODO why cast to list here ?
482-
for name, obj in list(self._objects.items()):
477+
for name, obj in self._objects.items():
483478
assert hasattr(obj, "name")
484479
if obj.name not in self._names_list:
485480
# Object no longer exists

0 commit comments

Comments
 (0)