Skip to content

Commit b5729df

Browse files
author
anon
committed
remove unused --spinner default
(cherry picked from commit f9858b1)
1 parent 43e9913 commit b5729df

3 files changed

Lines changed: 11 additions & 14 deletions

File tree

doc/manpages/qvm-ls.rst

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Synopsis
77
--------
88

99
:command:`qvm-ls` [--verbose] [--quiet] [--help] [--all]
10-
[--exclude *EXCLUDE*] [--spinner] [--no-spinner]
10+
[--exclude *EXCLUDE*] [--no-spinner]
1111
[--format *FORMAT* | --fields *FIELD*[,*FIELD* ...]]
1212
[--tree] [--raw-data] [--help-formats]
1313
[--help-columns] [--class *CLASS* [*CLASS* ...]]
@@ -53,10 +53,6 @@ General options
5353
Exclude the qube from --all. You need to use --all option explicitly to use
5454
--exclude.
5555

56-
.. option:: --spinner
57-
58-
Have a spinner spinning while the spinning mainloop spins new table cells.
59-
6056
.. option:: --no-spinner
6157

6258
No spinner today.

qubesadmin/tests/tools/qvm_ls.py

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -142,28 +142,33 @@ def test_104_wildcards(self):
142142
]
143143
)
144144
with qubesadmin.tests.tools.StdoutBuffer() as stdout:
145-
qubesadmin.tools.qvm_ls.main(['--raw-data', '--fields=name', 'fedora*'], app=app)
145+
qubesadmin.tools.qvm_ls.main(['--raw-data', '--fields=name',
146+
'fedora*'], app=app)
146147
self.assertEqual(stdout.getvalue(),
147148
'fedora-41\nfedora-41-minimal\nfedora-41-xfce\nfedora-rawhide\n')
148149

149150
with qubesadmin.tests.tools.StdoutBuffer() as stdout:
150-
qubesadmin.tools.qvm_ls.main(['--raw-data', '--fields=name', '*minimal'], app=app)
151+
qubesadmin.tools.qvm_ls.main(['--raw-data', '--fields=name',
152+
'*minimal'], app=app)
151153
self.assertEqual(stdout.getvalue(),
152154
'debian-13-minimal\nfedora-41-minimal\n')
153155

154156
with qubesadmin.tests.tools.StdoutBuffer() as stdout:
155-
qubesadmin.tools.qvm_ls.main(['--raw-data', '--fields=name', '????'], app=app)
157+
qubesadmin.tools.qvm_ls.main(['--raw-data', '--fields=name',
158+
'????'], app=app)
156159
self.assertEqual(stdout.getvalue(),
157160
'dom0\n')
158161

159162
with qubesadmin.tests.tools.StdoutBuffer() as stdout:
160-
qubesadmin.tools.qvm_ls.main(['--raw-data', '--fields=name', '??????-[rs]*'],
163+
qubesadmin.tools.qvm_ls.main(['--raw-data', '--fields=name',
164+
'??????-[rs]*'],
161165
app=app)
162166
self.assertEqual(stdout.getvalue(),
163167
'debian-sid\nfedora-rawhide\n')
164168

165169
with qubesadmin.tests.tools.StdoutBuffer() as stdout:
166-
qubesadmin.tools.qvm_ls.main(['--raw-data', '--fields=name', '??????-[!14s]*'],
170+
qubesadmin.tools.qvm_ls.main(['--raw-data', '--fields=name',
171+
'??????-[!14s]*'],
167172
app=app)
168173
self.assertEqual(stdout.getvalue(),
169174
'fedora-rawhide\n')

qubesadmin/tools/qvm_ls.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -733,10 +733,6 @@ def get_parser():
733733
parser_sort.add_argument('--ignore-case', action='store_true',
734734
default=False, help='ignore case distinctions when sorting')
735735

736-
parser.add_argument('--spinner',
737-
action='store_true', dest='spinner',
738-
help='reenable spinner')
739-
740736
parser.add_argument('--no-spinner',
741737
action='store_false', dest='spinner',
742738
help='disable spinner')

0 commit comments

Comments
 (0)