Cleanup qvm_shutdown#448
Conversation
hippalectryon-0
force-pushed
the
qvm_shutdown_cleanup_qubesmain
branch
from
c08d6eb to
e59cad6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
==========================================
+ Coverage 76.36% 76.59% +0.22%
==========================================
Files 53 53
Lines 9399 9374 -25
==========================================
+ Hits 7178 7180 +2
+ Misses 2221 2194 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The |
hippalectryon-0
force-pushed
the
qvm_shutdown_cleanup_qubesmain
branch
2 times, most recently
from
aebf5e4 to
84b193d
Compare
|
I removed the (not_)has_event branch and rebased on main. Tests fail as often on unrelated issues due to gitlab runners, I don't have the permissions to relaunch them, NB: there's 2-3 other files which contain |
Yes, I think so. |
hippalectryon-0
force-pushed
the
qvm_shutdown_cleanup_qubesmain
branch
from
84b193d to
17c9380
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026040702-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026032404-devel&flavor=update
Failed tests20 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/170766#dependencies 28 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:10 performance degradations
Remaining performance tests:101 tests
|
3 participants
Mostly cleanup, with subtle inner API call changes that shouldn't affect users
Major changes
7d730eb harmonize behavior when has/hasnot_event
When
have_eventsisFalse, after reaching timeout, the previous code callsKillon the filteredcurrent_vms = failed_domains(current_vms)current_vms = failed_domains(current_vms), whereas if it isTrueit callsKillon allthis_round_domains.The commit harmonises this behavior to always filter.
This slightly changes the API calls, as seen in the modified utests.
a37814a cleanup dead code around
args.waitThe current code does
From this point onward, if
not args.wait, either we exited viaerror, orremaining_domainsis empty (and then wereturnimmediately after).This makes most following code depending on
args.waitobsolete.Minor changes
7d730eb use a single asyncio interface for both cases where we do and don't have events
c08d6eb add utests
Note: this particular commit is mostly GenAI. Tests were reviewed manually.