qvm-device: add --force flag for dom0 device attachment

[nihalxkumar]

fixes: QubesOS/qubes-issues#10825

related: QubesOS/qubes-core-admin#798

[parulin]

It should also be documented.

[nihalxkumar]

It should also be documented.

Thanks @parulin. The introduction of this change is still in discussion. Would of course document it.

[marmarek]

The build fails because of missing man page entry:

11:59:54 [qb.build_rpm.core-admin-client.host-fc41.build] DEBUG: Undocumented arguments for command 'qvm-device attach': '--force, -f'

[rustybird]

When invoked without --force, IMO it should behave like qvm-remove or qvm-volume clear do when invoked without --force. They interactively prompt to confirm:

https://github.com/QubesOS/qubes-core-admin-client/blob/v4.3.30/qubesadmin/tools/qvm_volume.py#L175-L180

[ben-grande]

About the use of --force or a flag with another name, wait for a response to Rusty's comment on QubesOS/qubes-issues#10825 (comment).

[ben-grande]

Also, next time, don't use your main branch, create a separate branch for making commits. Now, if you force push to base on a different branch, I think Github will force close this PR, so keep as is.

[ben-grande]

Please add "Fixes: QubesOS/qubes-issues#10825" to the commit message.

[nihalxkumar]

@ben-grande commit message or PR description or both?

[ben-grande]

Both is better.