Skip to content

Commit 54b3271

Browse files
committed
address review: fix import placement and log message
- Move shutdown_domains import to top of module - Change log message to: 'Waiting for full shutdown %s (PCI devices assigned)'
1 parent 8881754 commit 54b3271

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

vmupdate/qube_connection.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
from vmupdate.agent.source.log_config import LOGPATH, LOG_FILE
3434
from vmupdate.agent.source.status import StatusInfo, FinalStatus
3535
from vmupdate.agent.source.common.process_result import ProcessResult
36+
from vmupdate.vmupdate import shutdown_domains
3637

3738

3839
class QubeConnection:
@@ -95,9 +96,8 @@ def __exit__(self, exc_type, exc_val, exc_tb):
9596
if self.qube.is_running() and not self._initially_running:
9697
if self._has_assigned_pci_devices(self.qube):
9798
self.logger.info(
98-
'Shutdown %s and wait for full shutdown '
99-
'(PCI devices assigned)', self.qube.name)
100-
from vmupdate.vmupdate import shutdown_domains
99+
'Waiting for full shutdown %s (PCI devices assigned)',
100+
self.qube.name)
101101
shutdown_domains([self.qube], self.logger)
102102
else:
103103
self.logger.info('Shutdown %s', self.qube.name)

0 commit comments

Comments
 (0)