Skip to content

Commit 7e81124

Browse files
committed
Merge remote-tracking branch 'origin/pr/196'
* origin/pr/196: vmupdate: fix --apps flag Pull request description: The feature `qubes-vm-update --apps` does not work as it never selects any AppVM, the point of this flag is to update all running AppVM so you don't have to restart them. Of course, and it's in the documentation, changes will be lost after reboot, this does not prevent from updating according templates, but this allows you to update without stopping work / running stuff. After this change, it only works with the associated flag `--force-update` because there are no known information about available updates for an appvm, and this is not pulled from the template information either. Thanks @alimirjamali for the diff!
2 parents 1fd93fc + 383bda4 commit 7e81124

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

vmupdate/vmupdate.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ def preselect_targets(args, app) -> Set[qubesadmin.vm.QubesVM]:
186186
targets.update([vm for vm in updatable
187187
if vm.klass == 'StandaloneVM'])
188188
if args.apps:
189-
targets.update({vm for vm in updatable
189+
targets.update({vm for vm in app.domains
190190
if vm.klass == 'AppVM' and vm.is_running()})
191191

192192
# user can target non-updatable vm if she like

0 commit comments

Comments
 (0)