How to file a helpful issue
The problem you're addressing (if any)
I want to be able to use qfile-agent in dom0 and when dealing with large files, I need to modify UPDATES_MAX_BYTES and UPDATES_MAX_FILES. Unfortunately, it does not validate the variables. If the variable is invalid, atoll() will convert it to 0, thus no limit is set instead of failing.
The solution you'd like
Fail when the user set a value different than zero and bytes_limit or files_limit is converted to 0.
The value to a user, and who that user might be
In order to complete
It must fail on invalid user input instead of allowing the user mistake to unlimit the values.
How to file a helpful issue
The problem you're addressing (if any)
I want to be able to use qfile-agent in dom0 and when dealing with large files, I need to modify
UPDATES_MAX_BYTESandUPDATES_MAX_FILES. Unfortunately, it does not validate the variables. If the variable is invalid,atoll()will convert it to0, thus no limit is set instead of failing.The solution you'd like
Fail when the user set a value different than zero and
bytes_limitorfiles_limitis converted to0.The value to a user, and who that user might be
In order to complete
It must fail on invalid user input instead of allowing the user mistake to unlimit the values.