Use admin utils wrappers for vm actions#212
Open
ben-grande wants to merge 1 commit into
Open
Conversation
This was referenced May 22, 2026
Contributor
Author
|
Still didn't test locally, but the main PR to core-admin-client and another very similar PR QubesOS/qubes-desktop-linux-manager@47565a5, were tested by openqa on https://openqa.qubes-os.org/tests/180820, and they did pass, so marking this PR as ready for review. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
==========================================
- Coverage 71.72% 71.37% -0.36%
==========================================
Files 12 12
Lines 1337 1331 -6
==========================================
- Hits 959 950 -9
- Misses 378 381 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jun 9, 2026
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026060922-devel&flavor=pull-requests Test run included the following:
Upload failures
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests19 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 24 fixed
Unstable testsDetails
Performance TestsPerformance degradation:28 performance degradations
Remaining performance tests:83 tests
|
This was referenced Jun 9, 2026
marmarek
requested changes
Jun 16, 2026
| self.logger.info('Shutdown %s', self.qube.name) | ||
| self.qube.shutdown() | ||
| wait = True | ||
| asyncio.run(shutdown_domains([self.qube], self.logger, wait=wait)) |
Member
There was a problem hiding this comment.
Simply self.qube.shutdown(wait=wait) here, since it has wait option now?
Contributor
Author
There was a problem hiding this comment.
I will push changes that resolve the merge conflict, and then will test if a freezed domain that tries to shutdown, will hang the progress of other qubes.
Contributor
Author
There was a problem hiding this comment.
Testcase, log "SLEEP" and sleep before that part, tail -F /var/log/qubes/update-QUBE.log, start update for 3 domains, max concurrency of 2 and try to update. Freeze the qube when it's sleeping. Notice the update of the 3rd qube continue, so it's not freezing everything.
The difference is that that with my code, the exception message only appears in the logs, while with your proposal, it appears on the console. I think your proposal is correct. I think that a combination of these solutions are correct in this case, because it should be logged to both places and raised on the console.
ben-grande
force-pushed
the
long-shutdown
branch
6 times, most recently
from
17dd664 to
522c046
Compare
ben-grande
force-pushed
the
long-shutdown
branch
from
522c046 to
19d64ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see: QubesOS/qubes-core-admin-client#469 (comment)
Didn't test locally, only know that unit tests pass.