Skip to content

Commit 043eeea

Browse files
committed
Move icon property to baseVM
Every baseVM has a label, it should also have an icon.
1 parent 2488f2b commit 043eeea

2 files changed

Lines changed: 17 additions & 17 deletions

File tree

qubes/vm/__init__.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,23 @@ def klass(self):
288288
"""Domain class name"""
289289
return type(self).__name__
290290

291+
@qubes.stateless_property
292+
def icon(self) -> str:
293+
"""freedesktop icon name, suitable for use in
294+
:py:meth:`PyQt4.QtGui.QIcon.fromTheme`"""
295+
raw_icon_name = self.label.name
296+
if self.klass == "TemplateVM":
297+
return "templatevm-" + raw_icon_name
298+
if self.features.get("servicevm", False):
299+
return "servicevm-" + raw_icon_name
300+
if self.klass == "DispVM":
301+
return "dispvm-" + raw_icon_name
302+
if self.klass == "StandaloneVM":
303+
return "standalonevm-" + raw_icon_name
304+
if self.klass == "RemoteVM":
305+
return "remotevm-" + raw_icon_name
306+
return "appvm-" + raw_icon_name
307+
291308
def close(self):
292309
super().close()
293310
del self.app

qubes/vm/qubesvm.py

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2692,23 +2692,6 @@ def start_time(self):
26922692

26932693
return None
26942694

2695-
@qubes.stateless_property
2696-
def icon(self) -> str:
2697-
"""freedesktop icon name, suitable for use in
2698-
:py:meth:`PyQt4.QtGui.QIcon.fromTheme`"""
2699-
raw_icon_name = self.label.name
2700-
if self.klass == "TemplateVM":
2701-
return "templatevm-" + raw_icon_name
2702-
if self.features.get("servicevm", False):
2703-
return "servicevm-" + raw_icon_name
2704-
if self.klass == "DispVM":
2705-
return "dispvm-" + raw_icon_name
2706-
if self.klass == "StandaloneVM":
2707-
return "standalonevm-" + raw_icon_name
2708-
if self.klass == "RemoteVM":
2709-
return "remotevm-" + raw_icon_name
2710-
return "appvm-" + raw_icon_name
2711-
27122695
@property
27132696
def kernelopts_common(self):
27142697
"""Kernel options which should be used in addition to *kernelopts*

0 commit comments

Comments
 (0)