Print string representation of preload feature

ben-grande · ben-grande · commit 1a2155add746 · 2025-10-07T16:09:45.000+02:00
Concatenating empty ('') value is lost on translation. For: QubesOS/qubes-issues#1512
diff --git a/qubes/vm/adminvm.py b/qubes/vm/adminvm.py
@@ -393,7 +393,7 @@ def on_feature_set_preload_dispvm_max(
             return
         if not (appvm := getattr(self.app, "default_dispvm", None)):
             return
-        reason = "global feature was set to " + str(value)
+        reason = "global feature was set to " + repr(value)
         asyncio.ensure_future(
             appvm.fire_event_async("domain-preload-dispvm-start", reason=reason)
         )
diff --git a/qubes/vm/mix/dvmtemplate.py b/qubes/vm/mix/dvmtemplate.py
@@ -143,7 +143,7 @@ def on_feature_set_preload_dispvm_max(
             return
         if self.is_global_preload_set():
             return
-        reason = "local feature was set to " + str(value)
+        reason = "local feature was set to " + repr(value)
         asyncio.ensure_future(
             self.fire_event_async("domain-preload-dispvm-start", reason=reason)
         )

Original file line number	Diff line number	Diff line change
`@@ -393,7 +393,7 @@ def on_feature_set_preload_dispvm_max(`
`393`	`393`	`return`
`394`	`394`	`if not (appvm := getattr(self.app, "default_dispvm", None)):`
`395`	`395`	`return`
`396`		`- reason = "global feature was set to " + str(value)`
	`396`	`+ reason = "global feature was set to " + repr(value)`
`397`	`397`	`asyncio.ensure_future(`
`398`	`398`	`appvm.fire_event_async("domain-preload-dispvm-start", reason=reason)`
`399`	`399`	`)`
Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ def on_feature_set_preload_dispvm_max(`
`143`	`143`	`return`
`144`	`144`	`if self.is_global_preload_set():`
`145`	`145`	`return`
`146`		`- reason = "local feature was set to " + str(value)`
	`146`	`+ reason = "local feature was set to " + repr(value)`
`147`	`147`	`asyncio.ensure_future(`
`148`	`148`	`self.fire_event_async("domain-preload-dispvm-start", reason=reason)`
`149`	`149`	`)`