Merge remote-tracking branch 'origin/pr/711'

* origin/pr/711:
  Fail early on missing necessary preload service

Pull request description:

Occurs when the global max preload feature, set on dom0, with the default-dispvm being an unsupported template, which can happen on old ISOs, old templates, downgraded templates or packages. When setting the dom0 feature or when switching the default-dispvm, there is no supported-rpc validation. Handle gracefully in case the qube is the default-dispvm and the global max feature is set.

Without this validation, it tries to preload and fails on startup check of the same supported-rpc, but this time, running it as a service.

For: QubesOS/qubes-issues#1512

Without it, doesn't break anything, but a minor annoyance of failing the `qubes-preload-dispvm.service` and `qubesd` logs and the preloads trying to start to just fail. This has more chance of happening with the global preload feature as it doesn't check if the default-dispvm supports the necessary RPC service.

Author: marmarek

qubes/vm/mix/dvmtemplate.py

@@ -124,8 +124,7 @@ def on_feature_pre_set_preload_dispvm_max(
             raise qubes.exc.QubesValueError("Qube does not support qrexec")
 
         service = "qubes.WaitForRunningSystem"
-        supported_service = "supported-rpc." + service
-        if not self.features.check_with_template(supported_service, False):
+        if not self.supports_preload():
             raise qubes.exc.QubesValueError(
                 "Qube does not support the RPC '%s'" % service
             )
@@ -283,7 +282,12 @@ async def on_domain_preload_dispvm_used(
         if delay:
             event_log += " with a delay of %s second(s)" % f"{delay:.1f}"
         self.log.info(event_log)
-
+        service = "qubes.WaitForRunningSystem"
+        if not self.supports_preload():
+            raise qubes.exc.QubesValueError(
+                "Qube does not support the RPC '%s' but tried to preload, "
+                "check if template is outdated" % service
+            )
         if delay:
             await asyncio.sleep(delay)
 
@@ -460,3 +464,12 @@ def remove_preload_excess(self, max_preload: Optional[int] = None) -> None:
                 if unwanted_disp in self.app.domains:
                     dispvm = self.app.domains[unwanted_disp]
                     asyncio.ensure_future(dispvm.cleanup())
+
+    def supports_preload(self) -> bool:
+        """Returns ``True`` if the necessary RPC is supported."""
+        assert isinstance(self, qubes.vm.BaseVM)
+        service = "qubes.WaitForRunningSystem"
+        supported_service = "supported-rpc." + service
+        if self.features.check_with_template(supported_service, False):
+            return True
+        return False