Initialize asyncio event loop before using it

Python 3.14 (in Fedora 43) throws RunetimeError if event loop is not
initialized before using it.

Resolves: QubesOS/qubes-issues#10188

Author: alimirjamali

doc/qubes-events.rst

@@ -177,8 +177,7 @@ handler (a coroutine) for synchronous event (the one fired with
 
    o = MyClass()
    o.events_enabled = True
-   loop = asyncio.get_event_loop()
-   loop.run_until_complete(o.fire_event_async('event1'))
+   asyncio.run(o.fire_event_async('event1'))
 
 Asynchronous event handlers can also return value - but only a collection, not
 yield individual values (because of python limitation):
@@ -207,7 +206,8 @@ yield individual values (because of python limitation):
 
    o = MyClass()
    o.events_enabled = True
-   loop = asyncio.get_event_loop()
+   loop = asyncio.new_event_loop()
+   asyncio.set_event_loop(loop)
    # returns ['sync result', 'result1', 'result2', 'result3', 'result4'],
    # possibly not in order
    effects = loop.run_until_complete(o.fire_event_async('event1'))

qubes/backup.py

@@ -256,7 +256,7 @@ class Backup:
     >>> }
     >>> backup_op = Backup(app, vms, exclude_vms, **options)
     >>> print(backup_op.get_backup_summary())
-    >>> asyncio.get_event_loop().run_until_complete(backup_op.backup_do())
+    >>> asyncio.run(backup_op.backup_do())
 
     See attributes of this object for all available options.
 

qubes/tests/__init__.py

@@ -513,7 +513,8 @@ def setUp(self):
         super().setUp()
         self.addCleanup(self.cleanup_gc)
 
-        self.loop = asyncio.get_event_loop()
+        self.loop = asyncio.new_event_loop()
+        asyncio.set_event_loop(self.loop)
         self.addCleanup(self.cleanup_loop)
 
         self.kernel_validator_original = qubes.app.validate_kernel

qubes/tests/api_admin.py

@@ -145,7 +145,8 @@ def call_mgmt_func(self, method, dest, arg=b"", payload=b""):
             self.app, b"dom0", method, dest, arg
         )
 
-        loop = asyncio.get_event_loop()
+        loop = asyncio.new_event_loop()
+        asyncio.set_event_loop(loop)
         response = loop.run_until_complete(
             mgmt_obj.execute(untrusted_payload=payload)
         )
@@ -158,7 +159,8 @@ def call_internal_mgmt_func(self, method, dest, arg=b"", payload=b""):
         mgmt_obj = qubes.api.internal.QubesInternalAPI(
             self.app, b"dom0", method, dest, arg
         )
-        loop = asyncio.get_event_loop()
+        loop = asyncio.new_event_loop()
+        asyncio.set_event_loop(loop)
         response = loop.run_until_complete(
             mgmt_obj.execute(untrusted_payload=payload)
         )
@@ -230,7 +232,8 @@ def test_002_vm_list_filter(self):
                 mgmt_obj = qubes.api.admin.QubesAdminAPI(
                     self.app, b"test-vm1", b"admin.vm.List", b"dom0", b""
                 )
-                loop = asyncio.get_event_loop()
+                loop = asyncio.new_event_loop()
+                asyncio.set_event_loop(loop)
                 value = loop.run_until_complete(
                     mgmt_obj.execute(untrusted_payload=b"")
                 )
@@ -3762,7 +3765,8 @@ def __init__(self, name):
             def name(self):
                 return self._name
 
-        loop = asyncio.get_event_loop()
+        loop = asyncio.new_event_loop()
+        asyncio.set_event_loop(loop)
         self.app.vmm.libvirt_conn.lookupByID.side_effect = lambda xid: {
             0: MockVM("Domain-0"),
             1: MockVM("test-template"),
@@ -3862,7 +3866,8 @@ def __init__(self, name):
             def name(self):
                 return self._name
 
-        loop = asyncio.get_event_loop()
+        loop = asyncio.new_event_loop()
+        asyncio.set_event_loop(loop)
         self.app.vmm.libvirt_conn.lookupByID.side_effect = lambda xid: {
             0: MockVM("Domain-0"),
             1: MockVM("test-template"),

qubes/tests/api_internal.py

@@ -79,7 +79,8 @@ def call_mgmt_func(self, method, arg=b"", payload=b""):
             self.app, b"dom0", method, b"dom0", arg
         )
 
-        loop = asyncio.get_event_loop()
+        loop = asyncio.new_event_loop()
+        asyncio.set_event_loop(loop)
         response = loop.run_until_complete(
             mgmt_obj.execute(untrusted_payload=payload)
         )

qubes/tests/api_misc.py

@@ -63,7 +63,8 @@ def call_mgmt_func(self, method, arg=b"", payload=b""):
             self.app, b"test-vm", method, b"dom0", arg
         )
 
-        loop = asyncio.get_event_loop()
+        loop = asyncio.new_event_loop()
+        asyncio.set_event_loop(loop)
         response = loop.run_until_complete(
             mgmt_obj.execute(untrusted_payload=payload)
         )

qubes/tests/devices_block.py

@@ -39,7 +39,8 @@ def async_test(f):
     def wrapper(*args, **kwargs):
         coro = asyncio.coroutine(f)
         future = coro(*args, **kwargs)
-        loop = asyncio.get_event_loop()
+        loop = asyncio.new_event_loop()
+        asyncio.set_event_loop(loop)
         loop.run_until_complete(future)
 
     return wrapper
@@ -1124,9 +1125,8 @@ def test_071_failed_confirmation(self, socket):
 
         socket.return_value = "allow:nonsense"
 
-        loop = asyncio.get_event_loop()
         self.ext.attach_and_notify = AsyncMock()
-        loop.run_until_complete(
+        asyncio.run(
             qubes.ext.utils.resolve_conflicts_and_attach(
                 self.ext, {"sda": {front: assign, back: assign}}
             )
@@ -1149,9 +1149,8 @@ def test_072_successful_confirmation(self, socket):
 
         socket.return_value = "allow:front-vm"
 
-        loop = asyncio.get_event_loop()
         self.ext.attach_and_notify = AsyncMock()
-        loop.run_until_complete(
+        asyncio.run(
             qubes.ext.utils.resolve_conflicts_and_attach(
                 self.ext, {"sda": {front: assign, back: assign}}
             )
@@ -1203,10 +1202,9 @@ def test_080_on_startup_multiple_assignments_including_full(self):
         )
 
         self.ext.attach_and_notify = Mock()
-        loop = asyncio.get_event_loop()
         with mock.patch("asyncio.wait"):
             with mock.patch("asyncio.ensure_future"):
-                loop.run_until_complete(self.ext.on_domain_start(front, None))
+                asyncio.run(self.ext.on_domain_start(front, None))
         self.assertEqual(
             self.ext.attach_and_notify.call_args[0][1].options, {"pid": "did"}
         )
@@ -1235,10 +1233,9 @@ def test_081_on_startup_multiple_assignments_port_vs_dev(self):
         )
 
         self.ext.attach_and_notify = Mock()
-        loop = asyncio.get_event_loop()
         with mock.patch("asyncio.wait"):
             with mock.patch("asyncio.ensure_future"):
-                loop.run_until_complete(self.ext.on_domain_start(front, None))
+                asyncio.run(self.ext.on_domain_start(front, None))
         self.assertEqual(
             self.ext.attach_and_notify.call_args[0][1].options, {"pid": "any"}
         )
@@ -1270,10 +1267,9 @@ def test_082_on_startup_multiple_assignments_dev(self):
         )
 
         self.ext.attach_and_notify = Mock()
-        loop = asyncio.get_event_loop()
         with mock.patch("asyncio.wait"):
             with mock.patch("asyncio.ensure_future"):
-                loop.run_until_complete(self.ext.on_domain_start(front, None))
+                asyncio.run(self.ext.on_domain_start(front, None))
         self.assertEqual(
             self.ext.attach_and_notify.call_args[0][1].options, {"any": "did"}
         )
@@ -1299,7 +1295,6 @@ def test_083_on_startup_already_attached(self):
         back.devices["block"]._exposed.append(exp_dev)
 
         self.ext.attach_and_notify = Mock()
-        loop = asyncio.get_event_loop()
         with mock.patch("asyncio.ensure_future"):
-            loop.run_until_complete(self.ext.on_domain_start(front, None))
+            asyncio.run(self.ext.on_domain_start(front, None))
         self.ext.attach_and_notify.assert_not_called()

qubes/tests/events.py

@@ -151,7 +151,8 @@ async def on_testevent_3(self, event):
             def on_testevent_4(self, event):
                 return ("testvalue4",)
 
-        loop = asyncio.get_event_loop()
+        loop = asyncio.new_event_loop()
+        asyncio.set_event_loop(loop)
         emitter = TestEmitter()
         emitter.events_enabled = True
 

qubes/tests/integ/backupcompatibility.py

@@ -473,7 +473,7 @@ def assertRestored(self, name, **kwargs):
 
         with self.assertNotRaises((KeyError, qubes.exc.QubesException)):
             vm = self.app.domains[name]
-            asyncio.get_event_loop().run_until_complete(vm.storage.verify())
+            asyncio.run(vm.storage.verify())
             for prop, value in kwargs.items():
                 if prop == "klass":
                     self.assertIsInstance(vm, value)

qubes/tools/qubes_create.py

@@ -40,7 +40,7 @@ def main(args=None):
     """
 
     args = parser.parse_args(args)
-    asyncio.get_event_loop().run_until_complete(
+    asyncio.run(
         qubes.Qubes.create_empty_store(
             args.app, offline_mode=args.offline_mode
         ).setup_pools()