Skip to content

Commit d464ce5

Browse files
committed
tests: update devices API argument serialization (cont)
Part 2 of: Device serialization for qrexec argument restrictions was fixed before, but tests still used old method. Update tests now too. Fixes: 6137b62 "Deserialize device from qrexec arg properly" QubesOS/qubes-issues#10040
1 parent 0c68a1d commit d464ce5

2 files changed

Lines changed: 10 additions & 5 deletions

File tree

qubes/tests/api_admin.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4069,7 +4069,7 @@ def test_650_vm_device_set_mode_required(self):
40694069
value = self.call_mgmt_func(
40704070
b"admin.vm.device.testclass.Set.assignment",
40714071
b"test-vm1",
4072-
b"test-vm1+1234:bee",
4072+
b"test-vm1+1234+bee",
40734073
b"required",
40744074
)
40754075

@@ -4113,7 +4113,7 @@ def test_651_vm_device_set_mode_ask(self):
41134113
value = self.call_mgmt_func(
41144114
b"admin.vm.device.testclass.Set.assignment",
41154115
b"test-vm1",
4116-
b"test-vm1+1234:bee",
4116+
b"test-vm1+1234+bee",
41174117
b"ask-to-attach",
41184118
)
41194119

@@ -4156,7 +4156,7 @@ def test_652_vm_device_set_mode_auto(self):
41564156
value = self.call_mgmt_func(
41574157
b"admin.vm.device.testclass.Set.assignment",
41584158
b"test-vm1",
4159-
b"test-vm1+1234:bee",
4159+
b"test-vm1+1234+bee",
41604160
b"auto-attach",
41614161
)
41624162

@@ -4194,7 +4194,7 @@ def test_653_vm_device_set_mode_unchanged(self):
41944194
value = self.call_mgmt_func(
41954195
b"admin.vm.device.testclass.Set.assignment",
41964196
b"test-vm1",
4197-
b"test-vm1+1234:bee",
4197+
b"test-vm1+1234+bee",
41984198
b"required",
41994199
)
42004200
self.assertIsNone(value)

qubes/tests/devices_pci.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,12 @@ def test_010_unassign_missing(self):
281281
b"dom0",
282282
b"admin.vm.device.pci.Unassign",
283283
b"testvm",
284-
("dom0+" + missing_port_id + ":" + missing_device_id).encode(),
284+
(
285+
"dom0+"
286+
+ missing_port_id
287+
+ "+"
288+
+ missing_device_id.replace(":", "+")
289+
).encode(),
285290
)
286291

287292
response = self.loop.run_until_complete(

0 commit comments

Comments
 (0)