Skip to content

Commit f05fe62

Browse files
committed
Disable notification for denied property.GetAll call
It's expected to be denied when some properties are allowed but not all. QubesOS/qubes-issues#10534
1 parent eaa3c04 commit f05fe62

3 files changed

Lines changed: 15 additions & 0 deletions

File tree

Makefile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,8 @@ endif
195195
mkdir -p $(DESTDIR)/usr/libexec/qubes
196196
install -m 0644 qubes-rpc-policy/90-default.policy \
197197
$(DESTDIR)/etc/qubes/policy.d/90-default.policy
198+
install -m 0644 qubes-rpc-policy/91-admin-default-deny.policy \
199+
$(DESTDIR)/etc/qubes/policy.d/91-admin-default-deny.policy
198200
install -m 0644 qubes-rpc-policy/85-admin-backup-restore.policy \
199201
$(DESTDIR)/etc/qubes/policy.d/85-admin-backup-restore.policy
200202
cp qubes-rpc/qubes.FeaturesRequest $(DESTDIR)/etc/qubes-rpc/
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
## Do not modify this file, create a new policy file with a lower number in the
2+
## filename instead. For example `30-user.policy`.
3+
4+
## Default action is deny anyway, but add notify=no, as GetAll is expected to
5+
be called if some properties are allowed but not all, so mute the spurious
6+
notification
7+
8+
admin.vm.property.GetAll * @anyvm @anyvm deny notify=no
9+
admin.vm.property.GetAll * @anyvm @adminvm deny notify=no
10+
11+
admin.property.GetAll * @anyvm @anyvm deny notify=no
12+
admin.property.GetAll * @anyvm @adminvm deny notify=no

rpm_spec/core-dom0.spec.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -597,6 +597,7 @@ done
597597
%attr(0664,root,qubes) %config /etc/qubes/policy.d/85-admin-backup-restore.policy
598598
%attr(0664,root,qubes) %config /etc/qubes/policy.d/90-admin-default.policy
599599
%attr(0664,root,qubes) %config /etc/qubes/policy.d/90-default.policy
600+
%attr(0664,root,qubes) %config /etc/qubes/policy.d/91-admin-default-deny.policy
600601
%attr(0664,root,qubes) %config(noreplace) /etc/qubes/policy.d/include/admin-global-ro
601602
%attr(0664,root,qubes) %config(noreplace) /etc/qubes/policy.d/include/admin-global-rwx
602603
%attr(0664,root,qubes) %config(noreplace) /etc/qubes/policy.d/include/admin-local-ro

0 commit comments

Comments
 (0)