Fix handling larger root complex with PCI path#676
Merged
marmarek merged 1 commit intoQubesOS:mainfrom Apr 27, 2025
Merged
Conversation
Larger systems have multiple root buses, adjust handling appropriately.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
=======================================
Coverage 70.37% 70.38%
=======================================
Files 61 61
Lines 12898 12902 +4
=======================================
+ Hits 9077 9081 +4
Misses 3821 3821
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025042414-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update
Failed tests10 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/132953#dependencies 13 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:14 performance degradations
Remaining performance tests:58 tests
|
This was referenced Apr 25, 2025
HW42
reviewed
Apr 30, 2025
| dev[3:].replace(":", "_") | ||
| for dev in os.listdir(f"{SYSFS_BASE}/devices") | ||
| if dev.startswith("pci") | ||
| ] |
Contributor
There was a problem hiding this comment.
This matches more than actual root buses:
$ ls -1d /sys/devices/pci*
/sys/devices/pci-101-0
/sys/devices/pci-59-0
/sys/devices/pci0000:00
$
Those other devices are coming from xen-pciback. Given the usage of the result, harmless, I think, but probably not intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Larger systems have multiple root buses, adjust handling appropriately.