Wait for user session for preloaded disposables#757
Conversation
ben-grande
force-pushed
the
preload-delay-gui-daemon
branch
from
7351532 to
e28c131
Compare
ben-grande
force-pushed
the
preload-delay-gui-daemon
branch
2 times, most recently
from
22d069b to
4644fb9
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
==========================================
- Coverage 70.12% 70.11% -0.01%
==========================================
Files 61 61
Lines 14001 14017 +16
==========================================
+ Hits 9818 9828 +10
- Misses 4183 4189 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ben-grande
force-pushed
the
preload-delay-gui-daemon
branch
from
4644fb9 to
f66f7c3
Compare
|
It is taking a lot of time for the user session to complete... maybe there is something timing out? QubesOS/qubes-gui-agent-linux#251 (comment)
|
So, |
This is very strange because the long time doesn't happen when calling the script manually, only when calling from qubesd. The following is very fast (0.02-1.5s) (do not preload): time qvm-run -p --dispvm=default-dvm-gui --service qubes.WaitForSession
time qvm-run -p --dispvm=default-dvm-gui 'time /etc/qubes-rpc/qubes.WaitForSession'
time qvm-run -p --dispvm=default-dvm-gui 'time systemctl --user --wait is-system-running'So why is qubesd variant so slow? |
|
maybe add |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026042316-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026032404-devel&flavor=update
Failed tests43 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/170766#dependencies 32 fixed
Unstable testsDetails
Performance TestsPerformance degradation:11 performance degradations
Remaining performance tests:100 tests
|
This should not fail restoring a backup... (not sure if this PR is to blame, but it's likely) |
| return False | ||
| supported = True | ||
| missing_services = [] | ||
| for service in ["qubes.WaitForRunningSystem", "qubes.WaitForSession"]: |
There was a problem hiding this comment.
Just supporting qubes.WaitForSession RPC doesn't guarantee it supports late gui-daemon connection. I'll add some explicit feature about that.
There was a problem hiding this comment.
Fixed. This code remains the same, it changes only on vm/dispvm.py.
This was fixed. |
QubesOS/qubes-gui-agent-linux#251 (comment)
I don't know why |
ben-grande
force-pushed
the
preload-delay-gui-daemon
branch
from
f66f7c3 to
41714fd
Compare
|
Hum, what is the chance that OpenQA ran without QubesOS/qubes-notification-proxy@7b82428? I will run the integration tests but it seems to be working correctly.
|
By default, it resolves the link path literally, which causes problem if other commands do not run on the same directory the link is at. For: QubesOS/qubes-core-admin#757 For: QubesOS/qubes-notification-proxy#13 For: QubesOS/qubes-issues#9940 For: QubesOS/qubes-issues#1512
|
Decided to create another PR in case this one is not merged soon: #796 |
With the GUI agent patch, it can start before the GUI daemon connects, allowing the user session to complete. Wait both services to guarantee no enabled user or system service tries to start after the preload is used. Requires: QubesOS/qubes-gui-agent-linux#251 Requires: QubesOS/qubes-gui-agent-linux#255 Fixes: QubesOS/qubes-issues#9940 For: QubesOS/qubes-issues#1512
ben-grande
force-pushed
the
preload-delay-gui-daemon
branch
from
7d89a58 to
8376986
Compare
|
openQArun PR_LABEL=openqa-pending TEST=system_tests_gui_tools Triggering this for: |
* origin/pr/796: Close qmemman client with correct handler Pull request description: For: QubesOS/qubes-issues#1512 --- #757 (comment)
3 participants
With the GUI agent patch, it can start before the GUI daemon connects, allowing the user session to complete. Wait both services to guarantee no enabled user or system service tries to start after the preload is used.
Requires: QubesOS/qubes-gui-agent-linux#251
Requires: QubesOS/qubes-gui-agent-linux#255
Requires: QubesOS/qubes-core-agent-linux#647
Requires: QubesOS/qubes-core-qrexec#229
Fixes: QubesOS/qubes-issues#9940
For: QubesOS/qubes-issues#1512