Add label to system_info#786
Conversation
This is necessary to display qube colors in qrexec-policy-graph.
| else None | ||
| ), | ||
| "icon": str(domain.label.icon), | ||
| "label": str(domain.label.color), |
There was a problem hiding this comment.
See vm_events at the top of the file. See how icon was handled.
There was a problem hiding this comment.
Done! Thanks for the tip.
|
Will schedule this for openqa. Although tests are failing, it is because the test was not adapted to consider label. The code is fine. I still expect the test to be fixed. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026031319-4.3-debian&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026020304-devel&flavor=update Failed testsNo failures! Fixed failuresCompared to: https://openqa.qubes-os.org/tests/166096#dependencies Unstable testsDetailsPerformance TestsPerformance degradation:No issues Remaining performance tests:13 tests
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #786 +/- ##
==========================================
- Coverage 70.15% 70.09% -0.06%
==========================================
Files 61 61
Lines 13995 13995
==========================================
- Hits 9818 9810 -8
- Misses 4177 4185 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It should be fixed now. The codecov check is failing. Is it a problem I should fix as well? |
|
codecov/patch is more important on these kind of PRs. codecov/project reporting is weird sometimes with "indirect changes": https://app.codecov.io/gh/QubesOS/qubes-core-admin/pull/786/indirect-changes Please squash all commits into one. |
marmarek
left a comment
marmarek
left a comment
There was a problem hiding this comment.
it would be better to have this in one commit indeed, but it isn't too bad here
4 participants
This is necessary to display qube colors in qrexec-policy-graph (QubesOS/qubes-core-qrexec#222).