Increase dom0 scheduling weight#789
Conversation
This is wrong, it was correct at that time. |
Dropped |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #789 +/- ##
==========================================
- Coverage 70.15% 70.07% -0.09%
==========================================
Files 61 61
Lines 13995 13964 -31
==========================================
- Hits 9818 9785 -33
- Misses 4177 4179 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Please push the changes and edit the first post. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026032922-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026032404-devel&flavor=update
Failed tests26 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/170766#dependencies 28 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:13 performance degradations
Remaining performance tests:91 tests
|
It remained in the commit message. Plus, maybe better leave old line too? Just in case somebody switches scheduler to |
Dom0 is responsible for the UI and for critical background activities. In particular, it is on the critical path for VM start. Therefore, it should be prioritized over all other VMs to avoid priority inversion. Qubes OS has always granted dom0 additional scheduling credit in the credit scheduler. However, Xen has since switched from the credit scheduler to the credit2 scheduler. Therefore, changing parameters in the credit scheduler no longer has any effect. Give dom0 the same amount additional credit in the credit2 scheduler as well, so that it does not matter which scheduler is used. Fixes: QubesOS/qubes-issues#10778 Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
DemiMarie
force-pushed
the
dom0-extra-credit
branch
from
0caeb9f to
5ba3415
Compare
Addressed |
4 participants
Dom0 is responsible for the UI and for critical background activities. In particular, it is on the critical path for VM start. Therefore, it should be prioritized over all other VMs to avoid priority inversion.
Dom0 has been intended to have additional credit since a179894 ("Initial public commit."), but nowadays Xen uses the credit2 scheduler, so changing the parameters of the credit scheduler has no effect.
Fixes: QubesOS/qubes-issues#10778