ext/block: fix reporting which device is attached#792
Conversation
The get_device_attachments() function is supposed to handle devices of a specific VM, but it reported them from all the VMs. If there were devices with the same port_id but in different backend VMs, it could result in wrong device being reported as attached. This especially affected events about attach/detach, which can confuse devices widget. Fix it be actually checking what is the backend VM of a given device. Fixes QubesOS/qubes-issues#10803
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
==========================================
- Coverage 70.15% 70.05% -0.10%
==========================================
Files 61 61
Lines 13995 13964 -31
==========================================
- Hits 9818 9783 -35
- Misses 4177 4181 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026032504-4.3&flavor=pull-requests Test run included the following:
Upload failures
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026020304-devel&flavor=update
Failed tests15 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/166096#dependencies 33 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:21 performance degradations
Remaining performance tests:89 tests
|
2 participants
The get_device_attachments() function is supposed to handle devices of a
specific VM, but it reported them from all the VMs. If there were
devices with the same port_id but in different backend VMs, it could
result in wrong device being reported as attached.
This especially affected events about attach/detach, which can confuse
devices widget.
Fix it be actually checking what is the backend VM of a given device.
Fixes QubesOS/qubes-issues#10803