tests: fix failure handling in test_031_firewall_dynamic_block#795
tests: fix failure handling in test_031_firewall_dynamic_block#795marmarek merged 1 commit intoQubesOS:mainfrom
Conversation
If the test fails early, client1 and/or client2 may be not set yet. Handle that case, to not fail in the 'finally' section.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #795 +/- ##
=======================================
Coverage 70.11% 70.11%
=======================================
Files 61 61
Lines 13997 13997
=======================================
Hits 9814 9814
Misses 4183 4183
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026032922-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026032404-devel&flavor=update
Failed tests26 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/170766#dependencies 28 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:13 performance degradations
Remaining performance tests:91 tests
|
If the test fails early, client1 and/or client2 may be not set yet.
Handle that case, to not fail in the 'finally' section.