tests: Add an environment sync test to TC_20_NonAudio#804
tests: Add an environment sync test to TC_20_NonAudio#804ArrayBolt3 wants to merge 1 commit intoQubesOS:mainfrom
Conversation
ArrayBolt3
force-pushed
the
arraybolt3/env-sync-test
branch
from
c769b63 to
4584eae
Compare
marmarek
left a comment
marmarek
left a comment
There was a problem hiding this comment.
Besides few technical comments, there is one more important factor (especially for the shell variable case): whether the command runs as part of user (GUI) session, or not. You can force either mode via:
- to force running inside existing session - add wait_for_session call
- to force running outside of it - specify different user (for example root).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
=======================================
Coverage 70.12% 70.12%
=======================================
Files 61 61
Lines 14001 14001
=======================================
Hits 9818 9818
Misses 4183 4183
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is what I want in all situations here, but I think I'm doing this already? I have |
ArrayBolt3
force-pushed
the
arraybolt3/env-sync-test
branch
from
4584eae to
531cd25
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026042817-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026032404-devel&flavor=update
Failed tests43 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/170766#dependencies 27 fixed
Unstable testsDetails
Performance TestsPerformance degradation:No issues Remaining performance tests:39 tests
|
|
Alright, so we get binary content with a newline at the end, now I know. Will fix. |
I'd prefer not inserting the newline in the printf format than stripping it later. |
Multiple bugs in Qubes have been the result of the either the user session or the systemd user manager missing environment variables that were set in /etc/profile.d (see Qubes issues #10299, #10712, #10759). We now have code that syncs the environment from the systemd user manager into a user session, and vice versa. Add tests that ensure environment variables are being synced both ways without clobbering values that are supposed to be augmented.
ArrayBolt3
force-pushed
the
arraybolt3/env-sync-test
branch
from
531cd25 to
e96f1a9
Compare
|
@ben-grande Done. |
4 participants
Multiple bugs in Qubes have been the result of the either the user session or the systemd user manager missing environment variables that were set in /etc/profile.d (see Qubes issues #10299, #10712, #10759). We now have code that syncs the environment from the systemd user manager into a user session, and vice versa. Add tests that ensure environment variables are being synced both ways without clobbering values that are supposed to be augmented.
Note that this test will fail without QubesOS/qubes-gui-agent-linux#257. Also, this is completely untested and unlinted, as I don't have a machine for running integration tests locally, and pylint is broken for Qubes repos on Fedora 43 (or at least was last I tried it). I didn't immediately see any code that deletes VMs that are created during the test process, so I've made no effort to clean up the StandaloneVMs this code creates, assuming it will be automatically cleaned up.