Skip to content

Return appropriate exception when libvirt shutdown times out #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marmarek merged 4 commits into from
May 22, 2026
+168 −49

Avoid hanging qubesd on unresponsive domU shutdown

bc93a9b
Select commit
Loading
Failed to load commit list.
Merged

Return appropriate exception when libvirt shutdown times out #807

Avoid hanging qubesd on unresponsive domU shutdown
bc93a9b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 21, 2026 in 1s

70.33% (+0.09%) compared to 71b5ab2

View this Pull Request on Codecov

70.33% (+0.09%) compared to 71b5ab2

Details

Codecov Report

❌ Patch coverage is 55.35714% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.33%. Comparing base (71b5ab2) to head (bc93a9b).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
qubes/app.py 47.36% 20 Missing ⚠️
qubes/vm/qubesvm.py 72.22% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
+ Coverage   70.24%   70.33%   +0.09%     
==========================================
  Files          61       61              
  Lines       14073    14095      +22     
==========================================
+ Hits         9885     9914      +29     
+ Misses       4188     4181       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov