Add support for default standalone boot modes#813
Open
ArrayBolt3 wants to merge 1 commit into
Open
Conversation
ArrayBolt3
force-pushed
the
arraybolt3/standalone-default
branch
from
202d550 to
6b4621c
Compare
Member
|
Tests are missing lines like this in expected calls: |
ArrayBolt3
force-pushed
the
arraybolt3/standalone-default
branch
from
6b4621c to
409754f
Compare
Contributor
Author
|
Fixed. (I noticed the tests failed earlier today and was planning on getting to this, but then forgot, so thank you for the ping :) ) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #813 +/- ##
==========================================
- Coverage 70.47% 70.34% -0.13%
==========================================
Files 61 61
Lines 14139 14145 +6
==========================================
- Hits 9964 9951 -13
- Misses 4175 4194 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Looking at the codecov output, it makes me realize the integration tests I created aren't really comprehensive (they make sure that a normal boot mode transition works, but don't test what happens if the transition isn't possible or what happens when trying to transition to the "default" mode). It's probably worth testing those edge cases too. I can add those tests once I have confirmation that the existing tests look right. |
marmarek
requested changes
Jun 6, 2026
ArrayBolt3
force-pushed
the
arraybolt3/standalone-default
branch
from
409754f to
5fc9924
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026070101-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests32 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 16 fixed
Unstable testsDetails
Performance TestsPerformance degradation:31 performance degradations
Remaining performance tests:80 tests
|
This was referenced Jun 15, 2026
marmarek
reviewed
Jun 15, 2026
ArrayBolt3
force-pushed
the
arraybolt3/standalone-default
branch
from
5fc9924 to
c859386
Compare
This was referenced Jun 26, 2026
This was referenced Jun 26, 2026
Member
:( |
ArrayBolt3
force-pushed
the
arraybolt3/standalone-default
branch
from
c859386 to
b0ff771
Compare
Contributor
Author
|
Should be fixed now. |
When a standalone is cloned from a template, the usual default boot mode of the standalone is the same as the boot mode the template originally used. In some instances this is undesirable; Kicksecure for instance puts its templates into a "sysmaint" boot mode that impairs standalone functionality. To fix this, add a new qvm-feature, "boot-mode.standalone-default", which states which boot mode a standalone should be switched to when its root volume is cloned from any other VM. (Note that cloning a standalone from another standalone will switch it to the boot mode specified by "boot-mode.standalone-default", cloning a template isn't the only way to trigger this.) Allows fixing QubesOS/qubes-issues#10514, but does not fix this bug by itself.
ArrayBolt3
force-pushed
the
arraybolt3/standalone-default
branch
from
b0ff771 to
33b03e9
Compare
This was referenced Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a standalone is cloned from a template, the usual default boot mode of the standalone is the same as the boot mode the template originally used. In some instances this is undesirable; Kicksecure for instance puts its templates into a "sysmaint" boot mode that impairs standalone functionality.
To fix this, add a new qvm-feature, "boot-mode.standalone-default", which states which boot mode a standalone should be switched to when its root volume is cloned from any other VM. (Note that cloning a standalone from another standalone will switch it to the boot mode specified by "boot-mode.standalone-default", cloning a template isn't the only way to trigger this.)
Allows fixing QubesOS/qubes-issues#10514, but does not fix this bug by itself.
I've tested the main code of this on my R4.3 machine, and it seems to work. The test code is untested though, and I'd be surprised if the integration tests are actually correct as-is. Note also that I only implemented integration tests for the actual "change boot mode on root volume clone" part of this, since I couldn't figure out how to sanely implement normal tests. Thus coverage.py will probably be unhappy with this.