tests: add missing test cleanup#816
Merged
Merged
Conversation
This was referenced May 31, 2026
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026060617-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests22 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 22 fixed
Unstable testsDetails
Performance TestsPerformance degradation:20 performance degradations
Remaining performance tests:91 tests
|
This was referenced May 31, 2026
Add disk2 status and update volume retrieval method
QubesOS/qubes-desktop-linux-i3-settings-qubes#23
Open
Member
Author
|
PipelineRetry |
skip_kernel_validation_patch was not stopped, and keeps reference to some objects. This also requires setUp() being called consistently - fix this one in rpc_import tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
==========================================
- Coverage 70.42% 70.40% -0.02%
==========================================
Files 61 61
Lines 14112 14145 +33
==========================================
+ Hits 9938 9959 +21
- Misses 4174 4186 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There is a code that drops references to Qubes* objects saved directly in test instance attributes already. But 274bb39 "Set deferred netvm for paused clients on shutdown" introduced also a list of such objects, which weren't cleaned up. Fix it by considering lists too - if first element is a qubes object, remove the whole list. Fixes: 274bb39 "Set deferred netvm for paused clients on shutdown"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skip_kernel_validation_patch was not stopped, and keeps reference to
some objects.