Skip to content

Clean up distinguished but equivalent path in vmid_to_ipv4#823

Draft
minitech wants to merge 1 commit into
QubesOS:mainfrom
minitech:patch-1
Draft

Clean up distinguished but equivalent path in vmid_to_ipv4#823
minitech wants to merge 1 commit into
QubesOS:mainfrom
minitech:patch-1

Conversation

@minitech
Copy link
Copy Markdown

@minitech minitech commented Jun 7, 2026

For all vmids from 1 to 254, (vmid >> 8, vmid & 0xff) == ((vmid - 1) // 254, (vmid - 1) % 254 + 1) == (0, vmid).

(Happened to come across this while working on something else and figured I’d put the patch up.)

For all `vmid`s from 1 to 254, `(vmid >> 8, vmid & 0xff) == ((vmid - 1) // 254, (vmid - 1) % 254 + 1) == (0, vmid)`.
@minitech minitech marked this pull request as draft June 7, 2026 03:12
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 7, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.35%. Comparing base (125cb5a) to head (7d9bdbd).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
qubes/vm/mix/net.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #823      +/-   ##
==========================================
- Coverage   70.42%   70.35%   -0.07%     
==========================================
  Files          61       61              
  Lines       14112    14086      -26     
==========================================
- Hits         9938     9910      -28     
- Misses       4174     4176       +2     
Flag Coverage Δ
unittests 70.35% <50.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant