Clean up distinguished but equivalent path in vmid_to_ipv4#823
Draft
minitech wants to merge 1 commit into
Draft
Conversation
For all `vmid`s from 1 to 254, `(vmid >> 8, vmid & 0xff) == ((vmid - 1) // 254, (vmid - 1) % 254 + 1) == (0, vmid)`.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #823 +/- ##
==========================================
- Coverage 70.42% 70.35% -0.07%
==========================================
Files 61 61
Lines 14112 14086 -26
==========================================
- Hits 9938 9910 -28
- Misses 4174 4176 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For all
vmids from 1 to 254,(vmid >> 8, vmid & 0xff) == ((vmid - 1) // 254, (vmid - 1) % 254 + 1) == (0, vmid).(Happened to come across this while working on something else and figured I’d put the patch up.)