Cleanup disposable on failed startup#847
Merged
Merged
Conversation
On "cleanup()" of a disposable with "auto_cleanup" enabled, if the state is: - Running: "_auto_cleanup" is called by the event "domain-shutdown" and not on "cleanup()", to avoid recalling it which would cause problems; - Halted: "_auto_cleanup" should be called if domain is not running, but that check is unreliable due to many moving parts, so "DispVM.start" should contain a "cleanup(force=True)" because in that case, we are sure to certain degree that it works, per my tests. Bug introduced on commit f1cbf21, which did not enforce "_auto_cleanup" on "DispVM.start" For: QubesOS#748 Fixes: QubesOS/qubes-issues#10928
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
==========================================
- Coverage 70.39% 70.33% -0.07%
==========================================
Files 61 61
Lines 14169 14167 -2
==========================================
- Hits 9974 9964 -10
- Misses 4195 4203 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I have two ideas of why this bug was not discovered sooner:
Now to tests:
|
ben-grande
force-pushed
the
preload-low-mem
branch
2 times, most recently
from
July 20, 2026 16:34
cb5d91f to
0995216
Compare
Contributor
Author
|
openQArun TEST=system_tests_dispvm |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026072219-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests14 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 27 fixed
Unstable testsDetails
Performance TestsPerformance degradation:42 performance degradations
Remaining performance tests:69 tests
|
ben-grande
force-pushed
the
preload-low-mem
branch
from
July 20, 2026 20:04
0995216 to
005120a
Compare
The "request_mem" is done very early on "QubesVM.start", the error handling doesn't have "self.kill" as the domain is not running yet, and therefore it was skipping "_auto_cleanup". Make sure that early startup failures are property handled, not remaining disposable in the domains collection nor in the preload-dispvm list.
ben-grande
force-pushed
the
preload-low-mem
branch
from
July 20, 2026 20:09
005120a to
f296a88
Compare
Contributor
Author
|
openQArun TEST=system_tests_dispvm |
This was referenced Jul 20, 2026
Merged
marmarek
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On "cleanup()" of a disposable with "auto_cleanup" enabled, if the state is:
Bug introduced on commit f1cbf21, which did not enforce "_auto_cleanup" on "DispVM.start"
For: #748
Fixes: QubesOS/qubes-issues#10928
Tested locally, it works.