Explicit key size to silence cryptsetup warning#848
Open
ben-grande wants to merge 1 commit into
Open
Conversation
We trust cryptsetup to provide sane defaults, but being implicit logs
the following warning for every ephemeral volume on qube startup:
WARNING: Using default options for cipher (aes-xts-plain64, key
size 256 bits) that could be incompatible with older versions.
For plain mode, always use options --cipher, --key-size and if
no keyfile or keyring is used, then also --hash.
This is the reason why "--cipher" and "--key-size" are specified. A
better solution would be to silence the warning and be implicit, as we
don't care about the key for this volume, we'd always get the new
cryptsetup default, but I didn't find a way to silence this warning.
Fixes: QubesOS/qubes-issues#10989
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
==========================================
- Coverage 70.37% 70.36% -0.02%
==========================================
Files 61 61
Lines 14179 14212 +33
==========================================
+ Hits 9979 10000 +21
- Misses 4200 4212 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We trust cryptsetup to provide sane defaults, but being implicit logs the following warning for every ephemeral volume on qube startup:
This is the reason why "--cipher" and "--key-size" are specified. A better solution would be to silence the warning and be implicit, as we don't care about the key for this volume, we'd always get the new cryptsetup default, but I didn't find a way to silence this warning.
Fixes: QubesOS/qubes-issues#10989