Speed up device query#852
Draft
ben-grande wants to merge 7 commits into
Draft
Conversation
ben-grande
force-pushed
the
cache-devices
branch
from
July 23, 2026 15:36
7374fee to
753c7ef
Compare
ben-grande
marked this pull request as draft
July 23, 2026 15:40
ben-grande
force-pushed
the
cache-devices
branch
from
July 24, 2026 07:01
753c7ef to
7de7cf3
Compare
Each call was recording 1ms, now the calls are below that.
This function reimports the same information over and over and is time consuming when looping through multiple domains. Reduce listing USB devices while there is no cache from 2.8s to 0.5s.
Method 'startwith' adds considerable overhead.
Libvirt API can be quite slow on the methods for "listAllDevices" and "XMLDesc", aggravated in loops.
Draft
Although it doesn't help reduce the time to get the XML, as XMLDesc() is super slow, this helps cleanup the code a bit.
ben-grande
force-pushed
the
cache-devices
branch
from
July 24, 2026 13:46
7de7cf3 to
fe99eab
Compare
ben-grande
marked this pull request as ready for review
July 24, 2026 13:48
ben-grande
marked this pull request as draft
July 24, 2026 14:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was split from #819 and it does not contain commits that should be problematic (more tested), those were left out to #855.
TODO: