Skip to content

Format files with black 26.5.1#854

Merged
marmarek merged 1 commit into
QubesOS:mainfrom
ben-grande:black-26.5.1
Jul 24, 2026
Merged

Format files with black 26.5.1#854
marmarek merged 1 commit into
QubesOS:mainfrom
ben-grande:black-26.5.1

Conversation

@ben-grande

Copy link
Copy Markdown
Contributor

Cause it is asking to reformat on my recent pushes: https://gitlab.com/QubesOS/qubes-core-admin/-/jobs/15513318441.

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 18.18182% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.30%. Comparing base (b35f619) to head (c290253).

Files with missing lines Patch % Lines
qubes/storage/zfs.py 0.00% 6 Missing ⚠️
qubes/backup.py 0.00% 3 Missing ⚠️
qubes/device_protocol.py 0.00% 3 Missing ⚠️
qubes/dochelpers.py 0.00% 3 Missing ⚠️
qubes/app.py 0.00% 1 Missing ⚠️
qubes/rngdoc.py 0.00% 1 Missing ⚠️
qubes/tools/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
- Coverage   70.37%   70.30%   -0.07%     
==========================================
  Files          61       61              
  Lines       14175    14149      -26     
==========================================
- Hits         9975     9948      -27     
- Misses       4200     4201       +1     
Flag Coverage Δ
unittests 70.30% <18.18%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marmarek

Copy link
Copy Markdown
Member

Hm, is there an option to force specific format version? Or that requires freezing black version itself?

@ben-grande

Copy link
Copy Markdown
Contributor Author

Only found two options from the manual page:

  -S, --skip-string-normalization
                                  Don't normalize string quotes or prefixes.
  -C, --skip-magic-trailing-comma
                                  Don't use trailing commas as a reason to
                                  split lines.

And that wouldn't help broadly in the case of this PR.

@marmarek
marmarek merged commit dc50b55 into QubesOS:main Jul 24, 2026
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants