Skip to content

Commit 7014a24

Browse files
author
3np
committed
chore(network-agent): consistently memoize ip_address stringification
1 parent 385b4ab commit 7014a24

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

network/qubes-setup-dnat-to-ns

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -112,16 +112,18 @@ def install_firewall_rules(dns):
112112
# Or maybe user wants to enforce DNS-Over-HTTPS.
113113
# Drop IPv4 DNS requests to qubesdb_dns addresses.
114114
for vm_nameserver in qubesdb_dns:
115+
vm_ns_ = str(vm_nameserver)
115116
rules += [
116-
f"ip daddr {vm_nameserver} udp dport 53 drop",
117-
f"ip daddr {vm_nameserver} tcp dport 53 drop",
117+
f"ip daddr {vm_ns_} udp dport 53 drop",
118+
f"ip daddr {vm_ns_} tcp dport 53 drop",
118119
]
119120
else:
120121
for vm_nameserver, dest in zip(qubesdb_dns, cycle(dns_resolved)):
122+
vm_ns_ = str(vm_nameserver)
121123
dns_ = str(dest)
122124
rules += [
123-
f"ip daddr {vm_nameserver} udp dport 53 dnat to {dns_}",
124-
f"ip daddr {vm_nameserver} tcp dport 53 dnat to {dns_}",
125+
f"ip daddr {vm_ns_} udp dport 53 dnat to {dns_}",
126+
f"ip daddr {vm_ns_} tcp dport 53 dnat to {dns_}",
125127
]
126128
rules += ["}", "}"]
127129

0 commit comments

Comments
 (0)