Create filesystem on xvda1 on update

The new systemd (Debian trixie, Fedora 43) really insist on having
proper filesystem on the EFI partition, otherwise it marks several units
as failed. Create a filesystem there on package update too.

Fixes QubesOS/qubes-issues#8954

Author: marmarek

archlinux/PKGBUILD.install

@@ -85,6 +85,15 @@ update_qubesconfig() {
         mount /usr/local || :
     fi
 
+    rootdev=$(grep -o '^[^ ]* / ' /proc/mounts | cut -f 1 -d ' ') || rootdev=
+    # if root volume uses partitions, and is mounted directly (no dm-snapshot),
+    # check if xvda1 needs filesystem to be created
+    if [ -n "$rootdev" ] && [ "$(readlink -f "$rootdev")" = "/dev/xvda3" ]; then
+        if [ "$(file -s -b /dev/xvda1)" = "data" ]; then
+            /sbin/mkfs.vfat -S 4096 -n EFI /dev/xvda1
+        fi
+    fi
+
     # Install qubes version of fstab
     if ! grep -q dmroot /etc/fstab; then
         cp -f /etc/fstab.qubes /etc/fstab

debian/qubes-core-agent.postinst

@@ -166,6 +166,15 @@ case "${1}" in
             mount /usr/local || :
         fi
 
+        rootdev=$(grep -o '^[^ ]* / ' /proc/mounts | cut -f 1 -d ' ') || rootdev=
+        # if root volume uses partitions, and is mounted directly (no dm-snapshot),
+        # check if xvda1 needs filesystem to be created
+        if [ -n "$rootdev" ] && [ "$(readlink -f "$rootdev")" = "/dev/xvda3" ]; then
+            if [ "$(file -s -b /dev/xvda1)" = "data" ]; then
+                /sbin/mkfs.vfat -S 4096 -n EFI /dev/xvda1
+            fi
+        fi
+
         # remove old symlinks
         if [ -L /etc/systemd/system/sysinit.target.wants/qubes-random-seed.service ]; then
             rm /etc/systemd/system/sysinit.target.wants/qubes-random-seed.service

rpm_spec/core-agent.spec.in

@@ -574,6 +574,15 @@ if [ -L /usr/local ]; then
     mount /usr/local || :
 fi
 
+rootdev=$(grep -o '^[^ ]* / ' /proc/mounts | cut -f 1 -d ' ') || rootdev=
+# if root volume uses partitions, and is mounted directly (no dm-snapshot),
+# check if xvda1 needs filesystem to be created
+if [ -n "$rootdev" ] && [ "$(readlink -f "$rootdev")" = "/dev/xvda3" ]; then
+    if [ "$(file -s -b /dev/xvda1)" = "data" ]; then
+        /sbin/mkfs.vfat -S 4096 -n EFI /dev/xvda1
+    fi
+fi
+
 %if 0%{?fedora} < 41
 if [ ! -f /etc/qubes-dnf-hardened ]; then
     dnf config-manager --setopt=zchunk=0 --setopt=deltarpm=0 --save &&