Report failure reason on WaitForRunningSystem#647
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
=======================================
Coverage 71.71% 71.71%
=======================================
Files 3 3
Lines 502 502
=======================================
Hits 360 360
Misses 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026040600-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026032404-devel&flavor=update
Failed tests25 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/170766#dependencies 26 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:12 performance degradations
Remaining performance tests:99 tests
|
| rc=0 | ||
| systemctl --wait is-system-running || rc=$? | ||
| if test "$rc" -gt 0; then | ||
| LC_ALL=C TERM=dumb systemctl --failed --legend=no |
There was a problem hiding this comment.
Similar to the other PR: I'd prefer "error" to be printed to stderr, and leave stdout for possible future printing some structured data.
* origin/pr/757: Wait for user session for preloaded disposables Log preload startup failure reason Cleanup GUI extension to return early when viable Order GUI extension methods Pull request description: With the GUI agent patch, it can start before the GUI daemon connects, allowing the user session to complete. Wait both services to guarantee no enabled user or system service tries to start after the preload is used. Requires: QubesOS/qubes-gui-agent-linux#251 Requires: QubesOS/qubes-gui-agent-linux#255 Requires: QubesOS/qubes-core-agent-linux#647 Requires: QubesOS/qubes-core-qrexec#229 Fixes: QubesOS/qubes-issues#9940 For: QubesOS/qubes-issues#1512
3 participants
For: QubesOS/qubes-core-admin#757
For: QubesOS/qubes-issues#1512