Handle zramctl command failure gracefully#661
Open
Rudd-O wants to merge 1 commit into
Open
Conversation
Elide unnecessary failure when no zram devices are setup.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #661 +/- ##
=======================================
Coverage 71.71% 71.71%
=======================================
Files 3 3
Lines 502 502
=======================================
Hits 360 360
Misses 142 142 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jul 14, 2026
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026072219-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests14 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 27 fixed
Unstable testsDetails
Performance TestsPerformance degradation:42 performance degradations
Remaining performance tests:69 tests
|
This was referenced Jul 14, 2026
marmarek
requested changes
Jul 21, 2026
| systemctl daemon-reload | ||
| if command -v zramctl >/dev/null; then | ||
| zramctl -r zram0 | ||
| zramctl -r zram0 || true # Elide unnecessary failure when no zram devices are setup. |
Member
There was a problem hiding this comment.
What about checking if /dev/zram0 exists first?
This was referenced Jul 23, 2026
Merged
Contributor
Author
|
That would be a good idea. I am not at a console logged into GH to do this right now, and won't be for several days.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elide unnecessary failure when no zram devices are setup.