Better wait for network uplink#663
Merged
Merged
Conversation
qubes.WaitForNetworkUplink should wait for network to be completely up.
For that it checks for two things: whether relevant
qubes-network-uplink@ service is "active" and then whether relevant
network iterface is "UP". But, there is a race condition just after
network switch: interface may disappear already, but systemd still
hasn't noticed it. In that case, systemd unit will be active, while
interface will not be "UP" anymore. What should happen, is the service
should wait for systemd to notice and start the service again,
configuring the new interface, but it simply exited with an error in
this case.
Example log of this happening:
[ 39.009722] vif vif-0: xenbus: device forcefully removed from xenstore
[ 39.305470] xen_netfront: backend supports XDP headroom
[ 39.305549] vif vif-0: bouncing transmitted data to zeroed pages
[ 39.217586] qrexec-agent[1105]: 2026-07-17 21:47:35.395 qrexec-agent[1105]: qrexec-agent-data.c:278:handle_new_process_common: executed: root:QUBESRPC qubes.WaitForNetworkUplink dom0 (pid 1114)
...
[ 40.003229] qrexec-agent[1105]: 2026-07-17 21:47:36.223 qrexec-agent[1105]: qrexec-agent-data.c:314:handle_new_process_common: pid 1114 exited with 4
[ 40.052343] systemd[1]: Stopping qubes-network-uplink@eth0.service - Qubes network uplink (eth0) setup...
[ 40.130370] systemd[1]: qubes-network-uplink@eth0.service: Deactivated successfully.
[ 40.135065] systemd[1]: Stopped qubes-network-uplink@eth0.service - Qubes network uplink (eth0) setup.
[ 40.209447] systemd[1]: Starting qubes-network-uplink@eth0.service - Qubes network uplink (eth0) setup...
[ 40.501354] systemd-resolved[300]: eth0: Bus client set DNS server list to: 10.139.1.1, 10.139.1.2
[ 40.515630] systemd[1]: Finished qubes-network-uplink@eth0.service - Qubes network uplink (eth0) setup.
Modify the service to continue waiting in this case.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #663 +/- ##
=======================================
Coverage 71.71% 71.71%
=======================================
Files 3 3
Lines 502 502
=======================================
Hits 360 360
Misses 142 142 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jul 20, 2026
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026072016-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests15 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 21 fixed
Unstable testsDetails
Performance TestsPerformance degradation:28 performance degradations
Remaining performance tests:83 tests
|
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qubes.WaitForNetworkUplink should wait for network to be completely up.
For that it checks for two things: whether relevant
qubes-network-uplink@ service is "active" and then whether relevant
network iterface is "UP". But, there is a race condition just after
network switch: interface may disappear already, but systemd still
hasn't noticed it. In that case, systemd unit will be active, while
interface will not be "UP" anymore. What should happen, is the service
should wait for systemd to notice and start the service again,
configuring the new interface, but it simply exited with an error in
this case.
Example log of this happening:
Modify the service to continue waiting in this case.