Skip to content

Commit 77a5c32

Browse files
committed
Don't delete local policy on failures
Fixes: QubesOS/qubes-issues#10745
1 parent 1b7c113 commit 77a5c32

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

qrexec/tools/qubes_policy_editor.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,11 @@
2525

2626
from __future__ import print_function
2727
import argparse
28+
import os
2829
import subprocess
2930
import sys
3031
import tempfile
32+
3133
from ..policy.admin_client import PolicyClient
3234
from ..policy.admin import (
3335
PolicyAdminException,
@@ -90,7 +92,7 @@ def manage_policy(self) -> None:
9092
sys.exit(1)
9193

9294
# pylint: disable=consider-using-with
93-
tmpfile = tempfile.NamedTemporaryFile(suffix=suffix)
95+
tmpfile = tempfile.NamedTemporaryFile(suffix=suffix, delete=False)
9496

9597
if file_exists:
9698
with open(tmpfile.name, "w", encoding="utf-8") as current_file:
@@ -122,6 +124,7 @@ def manage_policy(self) -> None:
122124
sys.exit(1)
123125

124126
tmpfile.close()
127+
os.remove(self.tmpfile_name)
125128

126129
def get_reply(self) -> None:
127130
"""

0 commit comments

Comments
 (0)