[WIP] Limit parser target redirect to allowed list#133
Open
ben-grande wants to merge 1 commit into
Open
Conversation
Limits the parameters target= and default_target= to targets that have no previous deny rule. The previous rule file name and line number is not known and a general information is reported. Reported-by: unman <unman@thirdeyesecurity.org> Fixes: QubesOS/qubes-issues#8227
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 75.43% 75.44% +0.01%
==========================================
Files 52 52
Lines 8874 8882 +8
==========================================
+ Hits 6694 6701 +7
- Misses 2180 2181 +1 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Currently fails because collect_targets_for_ask removes valid values such as Waiting for discussion of before continuing. |
ben-grande
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limits the parameters target= and default_target= to targets that have no previous deny rule. The previous rule file name and line number is not known and a general information is reported.
Reported-by: unman unman@thirdeyesecurity.org
Fixes: QubesOS/qubes-issues#8227