Query GUIVM session or GUID from client in GUIVM by ben-grande · Pull Request #217 · QubesOS/qubes-core-qrexec

ben-grande · 2025-12-01T16:09:52Z

Read link to canonical path of GUID file

By default, it resolves the link path literally, which causes problem if other commands do not run on the same directory the link is at.

For: QubesOS/qubes-core-admin#757
For: QubesOS/qubes-notification-proxy#13
For: QubesOS/qubes-issues#9940
For: QubesOS/qubes-issues#1512

Allow GUIVM clients to know if GUIVM has session

Or if GUID of the client can be found on the server. This script will be
replicated to qubes-core-agent-linux.

For: QubesOS/qubes-notification-proxy#13
For: QubesOS/qubes-gui-agent-linux#251
For: QubesOS/qubes-core-admin#757
For: QubesOS/qubes-issues#1512
For: QubesOS/qubes-issues#9940
Fixes: QubesOS/qubes-issues#10443

Test case:

QREXEC_REMOTE_DOMAIN=mydomain /etc/qubes-rpc/qubes.WaitForSession

Please note that to avoid package conflicting (having the same file), it has to be handled with "less than version" compared to core-agent-linux

https://github.com/QubesOS/qubes-core-qrexec/compare/223f3b596259adf299988f1171df8572d0204a0c..0dc90060ad27e90487572f0609453b5c564f4be7

See required PR:

Allow GUIVM clients to know if GUIVM has session qubes-core-agent-linux#625

qubesos-bot · 2025-12-02T07:58:10Z

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026031512-4.3&flavor=pull-requests

Test run included the following:

Installing updates failed, skipping the report!

ben-grande · 2025-12-10T14:24:21Z

PipelineRetryFailed

marmarek · 2026-03-16T13:20:24Z

+wait_client_guid(){
+    qube="${1-}"
+    if test -z "$qube"; then
+        echo "QREXEC_REMOTE_DOMAIN variable needs to be set" >&2
+        exit 1
+    fi
+
+    prefix="/var/run/qubes"
+    if test "$in_dom0" = "true"; then
+        qrexec_name_sock="$prefix/qrexec.$qube"
+        if ! test -L "$qrexec_name_sock"; then
+            echo "$0: $qrexec_name_sock not found, domain might be dead" >&2
+            exit 1
+        fi
+        qrexec_id_sock="$(readlink -e "$qrexec_name_sock")"
+        if test -z "$qrexec_id_sock"; then
+            echo "$0: readlink failed for $qrexec_name_sock" >&2
+            exit 1
+        fi
+        xid="${qrexec_id_sock##*/qrexec.}"
+        guid_running="${qrexec_id_sock%/*}/guid-running.$xid"
+    else
+        xid="$(qvm-prefs -- "$qube" xid)"
+        guid_running="$(readlink -e "$prefix/guid-running.$xid")"
+    fi
+
+    while true; do
+        if test -f "$guid_running"; then
+            break
+        fi
+
+        if test "$in_dom0" = "true" && ! test -e "$qrexec_id_sock"; then
+            echo "$0: $qrexec_id_sock not found, domain might be dead" >&2
+            exit 1
+        fi
+
+        sleep 0.5
+    done
+    exit 0
+}


Hm, VM knows this already, I don't think there is a need to as GUI domain (which may be dom0) about it.
I specifically introduced status file for it: QubesOS/qubes-gui-agent-linux@a981e36

The code above allows querying GUID of any qube a GUI domain is responsible for. I guess there is no current use case for this (except if notification proxy is not running in GUIVM). For the case of notification-proxy where the service requires the client to have a session. It should be some loop on ExecStartPre= to wait for started, to not break preloaded disposables session startup.

It should be some loop on ExecStartPre= to wait for started, to not break preloaded disposables session startup.

If necessary at all, then yes, and ideally using inotify, not sleep (if going with shell, then inotifywait -e close_write might be the way to go).

But, there is QubesOS/qubes-notification-proxy#14, which makes the server side wait for the user login, so maybe that's enough already?

It should be some loop on ExecStartPre= to wait for started, to not break preloaded disposables session startup.

If necessary at all, then yes, and ideally using inotify, not sleep (if going with shell, then inotifywait -e close_write might be the way to go).

Hum, I thought that for some reason it was necessary, but openqa is succeeding so I guess this is fine.

But, there is QubesOS/qubes-notification-proxy#14, which makes the server side wait for the user login, so maybe that's enough already?

Yes, seems enough. Latest openqa failed installing packages. but edits shows that preload tests were succeeding.

codecov · 2026-03-16T13:28:18Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.86%. Comparing base (1fa231c) to head (0dc9006).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
- Coverage   78.98%   78.86%   -0.12%     
==========================================
  Files          55       55              
  Lines       10532    10530       -2     
==========================================
- Hits         8319     8305      -14     
- Misses       2213     2225      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ben-grande · 2026-03-17T00:06:43Z

PipelineRetryFailed

ben-grande · 2026-03-17T00:15:28Z

Do you want me to make the version changes in a separate commit to be easily excluded from when you cherry pick?

marmarek · 2026-03-17T00:25:44Z

Do you want me to make the version changes in a separate commit to be easily excluded from when you cherry pick?

Yes, or even drop it completely and just add a note in PR description.

Behavioral change, as it previously waited for GUID connection to the source qube. For: QubesOS/qubes-notification-proxy#13 For: QubesOS/qubes-gui-agent-linux#251 For: QubesOS/qubes-core-admin#757 For: QubesOS/qubes-issues#1512 For: QubesOS/qubes-issues#9940 Fixes: QubesOS/qubes-issues#10443

/etc/qubes-rpc/qubes.WaitForSession is migrating from core-agent-linux to this repository. See #217 for more details.

ben-grande force-pushed the preload-delay-gui-daemon branch from 9e32536 to 4c2c78d Compare December 1, 2025 16:37

marmarek added the openqa-pending label Dec 1, 2025

This was referenced Dec 2, 2025

Add Arch packaging QubesOS/qubes-core-admin-client#332

Open

tests: log more info on failure QubesOS/qubes-core-admin#736

Draft

Set deferred netvm for paused clients on shutdown QubesOS/qubes-core-admin#755

Merged

ben-grande mentioned this pull request Dec 2, 2025

Preloaded disposables QubesOS/qubes-issues#1512

Open

32 tasks

ben-grande changed the title ~~Read link to canonical path of GUID file~~ Query GUIVM session or GUID from client in GUIVM Dec 2, 2025

ben-grande force-pushed the preload-delay-gui-daemon branch 2 times, most recently from b953a27 to 081836a Compare December 2, 2025 17:44

This was referenced Dec 3, 2025

Allow GUIVM clients to know if GUIVM has session QubesOS/qubes-core-agent-linux#625

Merged

Allow GUIVM clients to know if GUIVM has session QubesOS/qubes-mgmt-salt-dom0-virtual-machines#88

Closed

ben-grande force-pushed the preload-delay-gui-daemon branch 6 times, most recently from df94a26 to 88935ab Compare December 4, 2025 11:13

This was referenced Mar 15, 2026

version 4.3.999 QubesOS/qubes-core-admin-client#454

Draft

Fix reporting error status for multi-command actions QubesOS/qubes-mgmt-salt-base#20

Merged

re-add qubesadmin.tags import QubesOS/qubes-core-admin-client#456

Merged

marmarek requested changes Mar 16, 2026

View reviewed changes

ben-grande force-pushed the preload-delay-gui-daemon branch from 5dc1b28 to 223f3b5 Compare March 16, 2026 21:53

ben-grande force-pushed the preload-delay-gui-daemon branch from 223f3b5 to 0dc9006 Compare March 17, 2026 01:13

marmarek added a commit that referenced this pull request Mar 17, 2026

Adjust package dependencies for clean update

8cfc60c

/etc/qubes-rpc/qubes.WaitForSession is migrating from core-agent-linux to this repository. See #217 for more details.

marmarek merged commit 0e1766a into QubesOS:main Mar 17, 2026
4 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Query GUIVM session or GUID from client in GUIVM#217

Query GUIVM session or GUID from client in GUIVM#217
marmarek merged 2 commits into
QubesOS:mainfrom
ben-grande:preload-delay-gui-daemon

ben-grande commented Dec 1, 2025 •

edited

Loading

Uh oh!

qubesos-bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

ben-grande commented Dec 10, 2025

Uh oh!

marmarek Mar 16, 2026

Uh oh!

ben-grande Mar 16, 2026

Uh oh!

marmarek Mar 16, 2026

Uh oh!

ben-grande Mar 17, 2026

Uh oh!

codecov Bot commented Mar 16, 2026 •

edited

Loading

Uh oh!

ben-grande commented Mar 17, 2026

Uh oh!

ben-grande commented Mar 17, 2026

Uh oh!

marmarek commented Mar 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ben-grande commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qubesos-bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OpenQA test summary

Uh oh!

ben-grande commented Dec 10, 2025

Uh oh!

marmarek Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

ben-grande Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

marmarek Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

ben-grande Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ben-grande commented Mar 17, 2026

Uh oh!

ben-grande commented Mar 17, 2026

Uh oh!

marmarek commented Mar 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ben-grande commented Dec 1, 2025 •

edited

Loading

qubesos-bot commented Dec 2, 2025 •

edited

Loading

codecov Bot commented Mar 16, 2026 •

edited

Loading