qrexec-policy-graph: add qube colors by notmuchtohide · Pull Request #222 · QubesOS/qubes-core-qrexec

notmuchtohide · 2026-02-28T22:48:12Z

Fixes QubesOS/qubes-issues#3007. I have not fixed the tests yet, but I believe the rest is ready for feedback.

Code decisions:

Node styling is not organized: Node styling is added as nodes are found instead of being grouped together. It should have no impact on the final graph and was considered as a potentially acceptable trade-off for implementation simplicity.
qubesadmin vs. system_info: The already used system_info did not provide qube colors, therefore it was obtained from qubesadmin.

Styling decisions:

Qube color was added to node borders in case of a literal qube (one that doesn't start with "@"). On non-literal qubes, nodes are dotted because it's not necessarily an individual qube.
The chosen style of coloring borders instead of solid filling made it easier to deal with the inner text (example: black text on black colored qubes).

Before

After

Fixes QubesOS/qubes-issues#3007 Code decisions: 1. Node styling is not organized: Node styling is added as nodes are found instead of being grouped together. It should have no impact on the final graph and was considered as a potentially acceptable trade-off for implementation simplicity. 2. qubesadmin vs. system_info: The already used system_info did not provide qube colors, therefore it was obtained from qubesadmin. Styling decisions: 1. Qube color was added to node borders in case of a literal qube (one that doesn't start with "@"). On non-literal qubes, nodes are dotted because it's not necessarily an individual qube. 2. The chosen style of coloring borders instead of solid filling made it easier to deal with the inner text (example: black text on black colored qubes).

ben-grande · 2026-03-02T17:56:00Z

2. qubesadmin vs. system_info: The already used system_info did not provide qube colors, therefore it was obtained from qubesadmin.

Then I believe that you could add label to system_info in qubes-core-admin instead of adding a dependency in qubesadmin.

Styling decisions:

1. Qube color was added to node borders in case of a literal qube (one that doesn't start with "@"). On non-literal qubes, nodes are dotted because it's not necessarily an individual qube.

I think that is okay.

2. The chosen style of coloring borders instead of solid filling made it easier to deal with the inner text (example: black text on black colored qubes).

I think that the border is too big with penwidth = 5. Without that, are the colors hard to distinguish because of being too thin?

Obtain label from system_info instead of adding a dependency in qubesadmin.

notmuchtohide · 2026-03-08T17:25:26Z

2. qubesadmin vs. system_info: The already used system_info did not provide qube colors, therefore it was obtained from qubesadmin.
Then I believe that you could add label to system_info in qubes-core-admin instead of adding a dependency in qubesadmin.

Done: QubesOS/qubes-core-admin#786

I think that the border is too big with penwidth = 5. Without that, are the colors hard to distinguish because of being too thin?

I believe the colors also look nice on thinner borders. I have now changed the width to 3.
This is how it looks now:

ben-grande · 2026-03-09T10:16:42Z

PipelineRetryFailed

ben-grande · 2026-03-09T10:34:07Z

PipelineRetryFailed

cairo-gobject at it again... will retry pipeline until it gets a functional runner.

ben-grande · 2026-03-09T11:02:38Z

CI failure seems to be related to missing the PR on core-admin. I believe that will be run by the gitlab runner when creating the openqa job.

marmarek · 2026-03-09T11:12:31Z

CI failure seems to be related to missing the PR on core-admin.

Tests have mockup system info structure, see qrexec/tests/policy_graph.py. And I'm pretty sure some of the tests will need an update to include the label too.

notmuchtohide · 2026-03-09T21:00:46Z

CI failure seems to be related to missing the PR on core-admin.

Tests have mockup system info structure, see qrexec/tests/policy_graph.py. And I'm pretty sure some of the tests will need an update to include the label too.

I believe I fixed the tests now.

The pipeline seems to be failing with the cairo-gobject that @ben-grande mentioned but the tests and lint are passing locally.

ben-grande · 2026-03-10T07:10:32Z

PipelineRetryFailed

ben-grande · 2026-03-10T07:37:12Z

Passed CI: https://gitlab.com/QubesOS/qubes-core-qrexec/-/pipelines/2373959020

gi problem for pylint, will ignore that and let this PR be scheduled for openqa.

ben-grande · 2026-03-10T07:37:22Z

PipelineRetryFailed

codecov · 2026-03-10T07:40:56Z

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.90%. Comparing base (cc801b8) to head (f4e05be).

Files with missing lines	Patch %	Lines
qrexec/tools/qrexec_policy_graph.py	94.73%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
+ Coverage   78.88%   78.90%   +0.02%     
==========================================
  Files          55       55              
  Lines       10531    10542      +11     
==========================================
+ Hits         8307     8318      +11     
  Misses       2224     2224

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

qubesos-bot · 2026-03-13T21:13:34Z

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026031319-4.3-debian&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026020304-devel&flavor=update

Failed tests

No failures!

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/166096#dependencies
Nothing fixed

Unstable tests

Details

Performance Tests

Performance degradation:

No issues

Remaining performance tests:

13 tests

debian-13-xfce_dom0-dispvm-api (mean:6.539): 78.47 🟢 ( previous job: 79.83, improvement: 98.29%)
debian-13-xfce_dom0-dispvm-gui-api (mean:7.827): 93.92 🔻 ( previous job: 92.49, degradation: 101.55%)
debian-13-xfce_dom0-dispvm-preload-2-api (mean:3.149): 37.79 🟢 ( previous job: 44.94, improvement: 84.08%)
debian-13-xfce_dom0-dispvm-preload-2-delay-0-api (mean:2.917): 35.00 🟢 ( previous job: 41.46, improvement: 84.42%)
debian-13-xfce_dom0-dispvm-preload-2-delay-minus-1d2-api (mean:3.307): 39.69 🟢 ( previous job: 47.01, improvement: 84.43%)
debian-13-xfce_dom0-dispvm-preload-4-api (mean:2.284): 27.41 🟢 ( previous job: 37.67, improvement: 72.75%)
debian-13-xfce_dom0-dispvm-preload-4-delay-0-api (mean:2.809): 33.71 🟢 ( previous job: 36.76, improvement: 91.71%)
debian-13-xfce_dom0-dispvm-preload-4-delay-minus-1d2-api (mean:2.441): 29.29 🟢 ( previous job: 37.87, improvement: 77.36%)
debian-13-xfce_dom0-dispvm-preload-2-gui-api (mean:4.989): 59.87 🔻 ( previous job: 55.58, degradation: 107.71%)
debian-13-xfce_dom0-dispvm-preload-4-gui-api (mean:4.135): 49.62 🔻 ( previous job: 47.73, degradation: 103.97%)
debian-13-xfce_dom0-dispvm-preload-6-gui-api (mean:4.198): 50.38 🔻 ( previous job: 47.11, degradation: 106.93%)
debian-13-xfce_dom0-vm-api (mean:0.038): 0.45 🔻 ( previous job: 0.41, degradation: 109.93%)
debian-13-xfce_dom0-vm-gui-api (mean:0.039): 0.47 🟢 ( previous job: 0.48, improvement: 96.67%)

* origin/pr/786: Add label to test_010 Add label to vm_events Add label to system_info Pull request description: This is necessary to display qube colors in qrexec-policy-graph (QubesOS/qubes-core-qrexec#222).

marmarek · 2026-05-11T21:03:00Z

This needs a rebase now...

notmuchtohide force-pushed the 3007-policy-graph-node-color branch from 8984c4c to 6770795 Compare March 1, 2026 01:00

notmuchtohide added 2 commits March 8, 2026 17:10

Obtain label from system_info

00e47d3

Obtain label from system_info instead of adding a dependency in qubesadmin.

Reduce graph node border

507611e

notmuchtohide force-pushed the 3007-policy-graph-node-color branch from e7b27fc to 507611e Compare March 8, 2026 17:11

notmuchtohide mentioned this pull request Mar 8, 2026

Add label to system_info QubesOS/qubes-core-admin#786

Merged

ben-grande added the openqa-group-2 label Mar 9, 2026

ben-grande removed the openqa-group-2 label Mar 9, 2026

tests: add qube color to system_info mock

f4e05be

ben-grande added the openqa-group-2 label Mar 10, 2026

This was referenced Mar 13, 2026

splitgpg2: allow xauthority OPTION for Flatpak clients QubesOS/qubes-app-linux-split-gpg2#33

Merged

Introduce audio-volume feature QubesOS/qubes-core-admin-client#405

Open

Integration tests for audio-initial-volume feature QubesOS/qubes-core-admin#768

Open

This was referenced Mar 13, 2026

Allow user to set qube audio volume QubesOS/qubes-gui-daemon#174

Open

Fix odict deprecation warnings QubesOS/qubes-mgmt-salt-base-topd#16

Merged

Conversation

notmuchtohide commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before

After

Uh oh!

ben-grande commented Mar 2, 2026

Uh oh!

notmuchtohide commented Mar 8, 2026

Uh oh!

ben-grande commented Mar 9, 2026

Uh oh!

ben-grande commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ben-grande commented Mar 9, 2026

Uh oh!

marmarek commented Mar 9, 2026

Uh oh!

notmuchtohide commented Mar 9, 2026

Uh oh!

ben-grande commented Mar 10, 2026

Uh oh!

ben-grande commented Mar 10, 2026

Uh oh!

ben-grande commented Mar 10, 2026

Uh oh!

codecov Bot commented Mar 10, 2026

Codecov Report

Uh oh!

qubesos-bot commented Mar 13, 2026

OpenQA test summary

New failures, excluding unstable

Failed tests

Fixed failures

Unstable tests

Performance Tests

Performance degradation:

Remaining performance tests:

Uh oh!

marmarek commented May 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

notmuchtohide commented Feb 28, 2026 •

edited

Loading

ben-grande commented Mar 9, 2026 •

edited

Loading